From 3e1d40fd7c55d2c4a94fee9ad146d5f95dd16b83 Mon Sep 17 00:00:00 2001
From: Aaron Daniels <aaron@daniels.id.au>
Date: Wed, 16 Mar 2016 08:37:15 +1000
Subject: [PATCH] - Added $vars to ajax_forms - replaced all instances of
 $_POST with $vars

---
 html/ajax_form.php                         |  1 +
 html/includes/forms/create-service.inc.php | 12 ++++++------
 html/includes/forms/delete-service.inc.php |  8 ++++----
 html/includes/forms/parse-service.inc.php  |  2 +-
 html/pages/addsrv.inc.php                  |  4 ++--
 html/pages/device/edit/services.inc.php    |  4 ++--
 6 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/html/ajax_form.php b/html/ajax_form.php
index 999a43a4d..93c8498f6 100644
--- a/html/ajax_form.php
+++ b/html/ajax_form.php
@@ -21,6 +21,7 @@ require_once '../includes/definitions.inc.php';
 require_once 'includes/functions.inc.php';
 require_once '../includes/functions.php';
 require_once 'includes/authenticate.inc.php';
+require_once 'includes/vars.inc.php';
 
 if (!$_SESSION['authenticated']) {
     echo 'unauthenticated';
diff --git a/html/includes/forms/create-service.inc.php b/html/includes/forms/create-service.inc.php
index e2e20a170..e92dbadba 100644
--- a/html/includes/forms/create-service.inc.php
+++ b/html/includes/forms/create-service.inc.php
@@ -16,12 +16,12 @@ if (is_admin() === false) {
     die('ERROR: You need to be admin');
 }
 
-$service_id = $_POST['service_id'];
-$type = mres($_POST['stype']);
-$desc = mres($_POST['desc']);
-$ip = mres($_POST['ip']);
-$param = mres($_POST['param']);
-$device_id = mres($_POST['device_id']);
+$service_id = $vars['service_id'];
+$type = mres($vars['stype']);
+$desc = mres($vars['desc']);
+$ip = mres($vars['ip']);
+$param = mres($vars['param']);
+$device_id = mres($vars['device_id']);
 
 if (is_numeric($service_id) && $service_id > 0) {
     // Need to edit.
diff --git a/html/includes/forms/delete-service.inc.php b/html/includes/forms/delete-service.inc.php
index fc1f1e8ee..65da3381c 100644
--- a/html/includes/forms/delete-service.inc.php
+++ b/html/includes/forms/delete-service.inc.php
@@ -15,15 +15,15 @@ if (is_admin() === false) {
     $status = array('status' =>1, 'message' => 'ERROR: You need to be admin to delete services');
 }
 else {
-    if (!is_numeric($_POST['service_id'])) {
+    if (!is_numeric($vars['service_id'])) {
         $status = array('status' =>1, 'message' => 'No Service has been selected');
     }
     else {
-        if (service_delete($_POST['service_id'])) {
-            $status = array('status' =>0, 'message' => 'Service: <i>'.$_POST['service_id'].', has been deleted.</i>');
+        if (service_delete($vars['service_id'])) {
+            $status = array('status' =>0, 'message' => 'Service: <i>'.$vars['service_id'].', has been deleted.</i>');
         }
         else {
-            $status = array('status' =>1, 'message' => 'Service: <i>'.$_POST['service_id'].', has NOT been deleted.</i>');
+            $status = array('status' =>1, 'message' => 'Service: <i>'.$vars['service_id'].', has NOT been deleted.</i>');
         }
     }
 }
diff --git a/html/includes/forms/parse-service.inc.php b/html/includes/forms/parse-service.inc.php
index f5a1bbb5e..a421e1a93 100644
--- a/html/includes/forms/parse-service.inc.php
+++ b/html/includes/forms/parse-service.inc.php
@@ -16,7 +16,7 @@ if (is_admin() === false) {
     die('ERROR: You need to be admin');
 }
 
-$service_id = $_POST['service_id'];
+$service_id = $vars['service_id'];
 
 if (is_numeric($service_id) && $service_id > 0) {
     $service = service_get(null, $service_id);
diff --git a/html/pages/addsrv.inc.php b/html/pages/addsrv.inc.php
index e0df8f313..db6b988ae 100644
--- a/html/pages/addsrv.inc.php
+++ b/html/pages/addsrv.inc.php
@@ -4,11 +4,11 @@ if ($_SESSION['userlevel'] < '10') {
     include 'includes/error-no-perm.inc.php';
 }
 else {
-    if ($_POST['addsrv']) {
+    if ($vars['addsrv']) {
         if ($_SESSION['userlevel'] >= '10') {
             $updated = '1';
 
-            $service_id = service_add($_POST['device'], $_POST['type'], $_POST['descr'], $_POST['ip'], $_POST['params'], 0);
+            $service_id = service_add($vars['device'], $vars['type'], $vars['descr'], $vars['ip'], $vars['params'], 0);
             if ($service_id) {
                 $message       .= $message_break.'Service added ('.$service_id.')!';
                 $message_break .= '<br />';
diff --git a/html/pages/device/edit/services.inc.php b/html/pages/device/edit/services.inc.php
index 7ca26baa0..6aa4a0e3e 100644
--- a/html/pages/device/edit/services.inc.php
+++ b/html/pages/device/edit/services.inc.php
@@ -1,11 +1,11 @@
 <?php
 
 if (is_admin() === true || is_read() === true) {
-    if ($_POST['addsrv']) {
+    if ($vars['addsrv']) {
         if ($_SESSION['userlevel'] >= '10') {
             $updated = '1';
 
-            $service_id = service_add($_POST['device'], $_POST['type'], $_POST['descr'], $_POST['ip'], $_POST['params'], 0);
+            $service_id = service_add($vars['device'], $vars['type'], $vars['descr'], $vars['ip'], $vars['params'], 0);
             if ($service_id) {
                 $message       .= $message_break.'Service added ('.$service_id.')!';
                 $message_break .= '<br />';