From 3e570a118edbe407c2261bbd64215e0d3893f993 Mon Sep 17 00:00:00 2001 From: laf Date: Mon, 16 Jun 2014 23:06:04 +0100 Subject: [PATCH] Tidied device setting pages --- html/pages/device/edit/alerts.inc.php | 53 +++---- html/pages/device/edit/apps.inc.php | 18 +-- html/pages/device/edit/device.inc.php | 96 +++++++------ html/pages/device/edit/ipmi.inc.php | 63 +++------ html/pages/device/edit/ports.inc.php | 42 +++--- html/pages/device/edit/snmp.inc.php | 195 +++++++++++++------------- 6 files changed, 223 insertions(+), 244 deletions(-) diff --git a/html/pages/device/edit/alerts.inc.php b/html/pages/device/edit/alerts.inc.php index 2e9679c11..be7bc7707 100644 --- a/html/pages/device/edit/alerts.inc.php +++ b/html/pages/device/edit/alerts.inc.php @@ -35,33 +35,26 @@ $disable_notify = get_dev_attrib($device,'disable_notify');

Alert settings

- - - - - - -
-
- - - - - - - - - - - - - - - -
/>
Override sysContact: value="" />
/>
Disable all alerting for this host
-
- -
-
-
-
+
+ +
+ +
+ /> +
+
+
+
+
+
+ value="" /> +
+
+
+ +
+ /> +
+
+ +
diff --git a/html/pages/device/edit/apps.inc.php b/html/pages/device/edit/apps.inc.php index 7807b2b48..d8450a15c 100644 --- a/html/pages/device/edit/apps.inc.php +++ b/html/pages/device/edit/apps.inc.php @@ -69,13 +69,14 @@ if (count($apps_enabled)) } } -echo("
-
+echo("
+
+ - +
- - + + "); @@ -86,19 +87,20 @@ foreach ($applications as $app) if (is_integer($row/2)) { $row_colour = $list_colour_a; } else { $row_colour = $list_colour_b; } echo(" "); - echo(" "); - echo(" "); + echo(" "); echo(" "); $row++; } -echo(''); +echo(''); echo('
EnableApplicationEnableApplication
"); + echo(" "); echo(" "); echo(" ". ucfirst($app) . "". ucfirst($app) . "
'); echo(''); echo('
'); +echo('
'); ?> diff --git a/html/pages/device/edit/device.inc.php b/html/pages/device/edit/device.inc.php index 8af554de0..3899e62f1 100644 --- a/html/pages/device/edit/device.inc.php +++ b/html/pages/device/edit/device.inc.php @@ -55,29 +55,24 @@ if ($updated && $update_message) } ?> - - - - -
-
-
- - - -
-
-
- - - - - - - - - - - - - - - - - - - - - -
Description:
- Type: - - + + +
+
+ +
+ +
+ +
+
+
+ +
+ -
/>
Override sysLocation: value="" />
Disable
/>
Ignore
/> 
- - - -
+ +
+ +
+ +
+
+ /> +
+
+
+
+
+
+
+ value="" /> +
+
+
+ +
+ /> +
+
+
+ +
+ /> +
+
+ +
- IPMI settings - - - - - - -
-
- - - - - - - - - - - - - - - - - - - - - - - -
IPMI/BMC Hostname
IPMI/BMC Username
IPMI/BMC Password
-
- -
- To disable IPMI polling, please clear the setting fields and click Save. -
-
-
-
+
+ +
+ +
+ +
+
+
+ +
+ +
+
+
+ +
+ +
+
+ +
+

To disable IPMI polling, please clear the setting fields and click Save.

diff --git a/html/pages/device/edit/ports.inc.php b/html/pages/device/edit/ports.inc.php index ddd87052c..11f68cacd 100644 --- a/html/pages/device/edit/ports.inc.php +++ b/html/pages/device/edit/ports.inc.php @@ -18,53 +18,52 @@ if ($updated && $update_message) } echo("
-
+ "); -echo(" +echo("
- - - - - - + + + + + + - + - - - + + + "); ?> ". $port['ifOperStatus'].""); echo(""); echo(""); echo(""); diff --git a/html/pages/device/edit/snmp.inc.php b/html/pages/device/edit/snmp.inc.php index efe910577..9281706d1 100644 --- a/html/pages/device/edit/snmp.inc.php +++ b/html/pages/device/edit/snmp.inc.php @@ -6,6 +6,7 @@ if ($_POST['editing']) { $community = mres($_POST['community']); $snmpver = mres($_POST['snmpver']); + $transport = mres($_POST['transport']); $port = mres($_POST['port']); $timeout = mres($_POST['timeout']); $retries = mres($_POST['retries']); @@ -22,7 +23,8 @@ if ($_POST['editing']) $update = array( 'community' => $community, 'snmpver' => $snmpver, - 'port' => $port + 'port' => $port, + 'transport' => $transport ); if ($_POST['timeout']) { $update['timeout'] = $timeout; } @@ -58,85 +60,84 @@ if ($updated && $update_message) print_error($update_message); } -echo("
IndexNameAdminOperDisableIgnoreIndexNameAdminOperDisableIgnore Description
"); - echo(""); + echo(""); echo(""); echo(""); - echo(""); + echo(""); echo(""); echo("".$port['ifAlias'] . "
-
- - +echo(" + - - - - - -
- -
- - - - - - +
+ +
+ +
-
- -
- - - - - - - - - - - - - - - - - - - - - - - - - - + + - - - - - - - - - - - - - - - - - - - "); + + +
+ +
+ +
+
+
+ +
+ (milli)seconds +
+
+
+ +
+ +
+
"); echo(' -
SNMP Version
- -
SNMPv1/v2c Configuration
SNMP Community
-
SNMPv3 Configuration
Auth Level
- + + +
+ +
+
+ +
+ -
Auth User Name
Auth Password
Auth Algorithm
- -
Crypto Password
Crypto Algorithm
- -
SNMP Connectivity
SNMP Transport
- + + +
+ +
+ +
+
+
+ +
+ +
+
+
+ +
+ +
+
+
+ +
+ +
+
+
+ +
+
+ +
+ -
SNMP Port
-
SNMP Timeout
  - (milli)seconds -
SNMP Retries
-
- - + -
'); +'); ?>