From 5d5376172719b4ea678f91a2e6f79196b2e18d97 Mon Sep 17 00:00:00 2001 From: Paul Gear Date: Sun, 16 Aug 2015 22:07:48 +1000 Subject: [PATCH] Trivial cleanups --- html/includes/table/device_mibs.inc.php | 2 +- html/pages/device/mib.inc.php | 2 +- includes/common.php | 8 ++++++++ includes/snmp.inc.php | 3 ++- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/html/includes/table/device_mibs.inc.php b/html/includes/table/device_mibs.inc.php index 086ef4140..6c109dc3e 100644 --- a/html/includes/table/device_mibs.inc.php +++ b/html/includes/table/device_mibs.inc.php @@ -34,7 +34,7 @@ function quote_sql_word($c) } -$params = array( +$params = array( $_POST['device_id'], ); diff --git a/html/pages/device/mib.inc.php b/html/pages/device/mib.inc.php index f6ecdb9a4..fc7f32b69 100644 --- a/html/pages/device/mib.inc.php +++ b/html/pages/device/mib.inc.php @@ -1,6 +1,6 @@ * diff --git a/includes/common.php b/includes/common.php index 6430ba308..929163c9b 100644 --- a/includes/common.php +++ b/includes/common.php @@ -739,6 +739,9 @@ function round_Nth($val = 0, $round_to) { } } // end round_Nth +/* + * FIXME: Dummy implementation + */ function count_mib_mempools($device) { if ($device['os'] == 'ruckuswireless') { @@ -747,6 +750,9 @@ function count_mib_mempools($device) return 0; } +/* + * FIXME: Dummy implementation + */ function count_mib_processors($device) { if ($device['os'] == 'ruckuswireless') { @@ -761,6 +767,7 @@ function count_mib_health($device) } /* + * FIXME: Dummy implementation * @return true if there is a custom graph defined for this type, subtype, and device */ function is_custom_graph($type, $subtype, $device) @@ -777,6 +784,7 @@ function is_custom_graph($type, $subtype, $device) } /* + * FIXME: Dummy implementation * Set section/graph entries in $graph_enable for graphs specific to $os. */ function enable_os_graphs($os, &$graph_enable) diff --git a/includes/snmp.inc.php b/includes/snmp.inc.php index 1f7d0e92f..d70f4e097 100644 --- a/includes/snmp.inc.php +++ b/includes/snmp.inc.php @@ -904,7 +904,8 @@ function snmp_mib_parse($oid, $mib, $module, $mibdir=null) { */ -function snmp_mib_walk($mib, $module, $mibdir=null) { +function snmp_mib_walk($mib, $module, $mibdir=null) +{ $cmd = 'snmptranslate -Ts'; $cmd .= mibdir($mibdir); $cmd .= ' -m '.$module;