From 81c4fc324433aef07fec7d512cf9eb63564606c6 Mon Sep 17 00:00:00 2001 From: Rasmus Aberg Date: Mon, 20 Jul 2015 10:46:35 +0200 Subject: [PATCH 1/3] Added power and temperature sensors for Extreme hardware (xos) --- includes/discovery/power/extreme.inc.php | 27 +++++++++++++++++++ .../discovery/temperatures/extreme.inc.php | 21 +++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 includes/discovery/power/extreme.inc.php create mode 100644 includes/discovery/temperatures/extreme.inc.php diff --git a/includes/discovery/power/extreme.inc.php b/includes/discovery/power/extreme.inc.php new file mode 100644 index 000000000..bc839d132 --- /dev/null +++ b/includes/discovery/power/extreme.inc.php @@ -0,0 +1,27 @@ + 0) { + discover_sensor($valid['sensor'], 'power', $device, $oid, '1', 'extreme-power', $descr, $divisor, 1, null, null, null, null, $value); // No limits have been specified since all equipment is different and will use different amount of Watts +} + +// EOF diff --git a/includes/discovery/temperatures/extreme.inc.php b/includes/discovery/temperatures/extreme.inc.php new file mode 100644 index 000000000..682d843d5 --- /dev/null +++ b/includes/discovery/temperatures/extreme.inc.php @@ -0,0 +1,21 @@ + 0) { + discover_sensor($valid['sensor'], 'temperature', $device, $oid, 1, 'extreme-temp', $descr, '1', '1', $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $value); + } +} + +// EOF From 0b880bff71fbacfe9cd48938008dc3604f467413 Mon Sep 17 00:00:00 2001 From: Rasmus Aberg Date: Mon, 20 Jul 2015 10:48:51 +0200 Subject: [PATCH 2/3] Added power and temperature sensors for Extreme hardware (xos) --- includes/discovery/power/extreme.inc.php | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/includes/discovery/power/extreme.inc.php b/includes/discovery/power/extreme.inc.php index bc839d132..21597237d 100644 --- a/includes/discovery/power/extreme.inc.php +++ b/includes/discovery/power/extreme.inc.php @@ -1,16 +1,5 @@ Date: Mon, 20 Jul 2015 11:01:30 +0200 Subject: [PATCH 3/3] Added power and temperature sensors for Extreme hardware (xos). I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md. --- AUTHORS.md | 1 + includes/discovery/power/extreme.inc.php | 4 ++-- .../discovery/temperatures/extreme.inc.php | 24 +++++++++---------- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/AUTHORS.md b/AUTHORS.md index 5150a6d0d..0a67718ba 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -39,6 +39,7 @@ Contributors to LibreNMS: - Travis Hegner (travishegner) - Will Jones (willjones) - Job Snijders (job) +- Rasmus Aberg (rasssta) [1]: http://observium.org/ "Observium web site" diff --git a/includes/discovery/power/extreme.inc.php b/includes/discovery/power/extreme.inc.php index 21597237d..39c9ca352 100644 --- a/includes/discovery/power/extreme.inc.php +++ b/includes/discovery/power/extreme.inc.php @@ -9,8 +9,8 @@ $value = snmp_get($device, $oid, '-Oqv', 'EXTREME-BASE-MIB'); $divisor = "1000"; $value = ($value / $divisor); // Nasty hack to divide the first value by 1000 since the divisor only works for polling after the sensor has been added -if (is_numeric($value) && $value > 0) { - discover_sensor($valid['sensor'], 'power', $device, $oid, '1', 'extreme-power', $descr, $divisor, 1, null, null, null, null, $value); // No limits have been specified since all equipment is different and will use different amount of Watts +if (is_numeric($value)) { + discover_sensor($valid['sensor'], 'power', $device, $oid, '1', 'extreme-power', $descr, $divisor, 1, null, null, null, null, $value); // No limits have been specified since all equipment is different and will use different amount of Watts } // EOF diff --git a/includes/discovery/temperatures/extreme.inc.php b/includes/discovery/temperatures/extreme.inc.php index 682d843d5..ae1cf86b1 100644 --- a/includes/discovery/temperatures/extreme.inc.php +++ b/includes/discovery/temperatures/extreme.inc.php @@ -1,21 +1,21 @@ 0) { - discover_sensor($valid['sensor'], 'temperature', $device, $oid, 1, 'extreme-temp', $descr, '1', '1', $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $value); - } + if (is_numeric($value)) { + discover_sensor($valid['sensor'], 'temperature', $device, $oid, 1, 'extreme-temp', $descr, '1', '1', $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $value); + } } // EOF