From c00df6d4c7b7d2d0d4da51686e0a40c0b4c4cdab Mon Sep 17 00:00:00 2001 From: Clint Armstrong Date: Wed, 22 Jul 2015 11:27:28 -0400 Subject: [PATCH 1/3] fix voltage alerts --- includes/discovery/voltages/drac.inc.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/discovery/voltages/drac.inc.php b/includes/discovery/voltages/drac.inc.php index b23453eff..2b7263735 100644 --- a/includes/discovery/voltages/drac.inc.php +++ b/includes/discovery/voltages/drac.inc.php @@ -21,9 +21,9 @@ if ($device['os'] == "drac") { $descr = trim(snmp_get($device, $descr_oid, "-Oqv", "IDRAC-MIB-SMIv2"),'"'); $descr = preg_replace("/(Status)/","", $descr); $current = snmp_get($device, $fan_oid, "-Oqv", "IDRAC-MIB-SMIv2"); - $low_limit = snmp_get($device, $limit_oid, "-Oqv", "IDRAC-MIB-SMIv2"); + $high_limit = snmp_get($device, $limit_oid, "-Oqv", "IDRAC-MIB-SMIv2"); $divisor = "1"; - discover_sensor($valid['sensor'], 'voltage', $device, $voltage_oid, $index, 'drac', $descr, $divisor, '1', $low_limit, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'voltage', $device, $voltage_oid, $index, 'drac', $descr, $divisor, '1', NULL, NULL, NULL, $high_limit, $current); } } } From 0f695b79402c7320776fb2d6ea750e092c46c2bd Mon Sep 17 00:00:00 2001 From: Clint Armstrong Date: Wed, 22 Jul 2015 11:46:22 -0400 Subject: [PATCH 2/3] fix oid name --- includes/discovery/voltages/drac.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/discovery/voltages/drac.inc.php b/includes/discovery/voltages/drac.inc.php index 2b7263735..fee08bbb8 100644 --- a/includes/discovery/voltages/drac.inc.php +++ b/includes/discovery/voltages/drac.inc.php @@ -20,7 +20,7 @@ if ($device['os'] == "drac") { $limit_oid = "powerSupplyMaximumInputVoltage.1.$index"; $descr = trim(snmp_get($device, $descr_oid, "-Oqv", "IDRAC-MIB-SMIv2"),'"'); $descr = preg_replace("/(Status)/","", $descr); - $current = snmp_get($device, $fan_oid, "-Oqv", "IDRAC-MIB-SMIv2"); + $current = snmp_get($device, $voltage_oid, "-Oqv", "IDRAC-MIB-SMIv2"); $high_limit = snmp_get($device, $limit_oid, "-Oqv", "IDRAC-MIB-SMIv2"); $divisor = "1"; discover_sensor($valid['sensor'], 'voltage', $device, $voltage_oid, $index, 'drac', $descr, $divisor, '1', NULL, NULL, NULL, $high_limit, $current); From e714953156cbc784eb38cef7ec02038ffbf00dca Mon Sep 17 00:00:00 2001 From: Clint Armstrong Date: Wed, 22 Jul 2015 11:55:21 -0400 Subject: [PATCH 3/3] set low limit to 0 --- includes/discovery/voltages/drac.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/discovery/voltages/drac.inc.php b/includes/discovery/voltages/drac.inc.php index fee08bbb8..e94ce8f02 100644 --- a/includes/discovery/voltages/drac.inc.php +++ b/includes/discovery/voltages/drac.inc.php @@ -23,7 +23,7 @@ if ($device['os'] == "drac") { $current = snmp_get($device, $voltage_oid, "-Oqv", "IDRAC-MIB-SMIv2"); $high_limit = snmp_get($device, $limit_oid, "-Oqv", "IDRAC-MIB-SMIv2"); $divisor = "1"; - discover_sensor($valid['sensor'], 'voltage', $device, $voltage_oid, $index, 'drac', $descr, $divisor, '1', NULL, NULL, NULL, $high_limit, $current); + discover_sensor($valid['sensor'], 'voltage', $device, $voltage_oid, $index, 'drac', $descr, $divisor, '1', 0, NULL, NULL, $high_limit, $current); } } }