diff --git a/html/forms/create-alert-item.inc.php b/html/forms/create-alert-item.inc.php index e11c56124..152733d2c 100644 --- a/html/forms/create-alert-item.inc.php +++ b/html/forms/create-alert-item.inc.php @@ -27,7 +27,7 @@ $invert = mres($_POST['invert']); $name = mres($_POST['name']); if(empty($rule)) { - $update_message = "ERROR: No rule was generated"; + $update_message = "ERROR: No rule was generated - did you forget to click and / or?"; } elseif(validate_device_id($_POST['device_id']) || $_POST['device_id'] == '-1' || $_POST['device_id'][0] == ':') { $device_id = $_POST['device_id']; if(!is_numeric($count)) { diff --git a/html/includes/modal/new_alert_rule.inc.php b/html/includes/modal/new_alert_rule.inc.php index 59f464e3b..0eba7bd0c 100644 --- a/html/includes/modal/new_alert_rule.inc.php +++ b/html/includes/modal/new_alert_rule.inc.php @@ -32,10 +32,15 @@ if(is_admin() !== false) { +
+
+ +
+
- +
@@ -61,15 +66,16 @@ if(is_admin() !== false) {
- +
- - + + +
@@ -126,7 +132,7 @@ if(is_admin() !== false) {
- +
@@ -303,6 +309,7 @@ $('#map-stub').typeahead({ $('#and, #or').click('', function(e) { e.preventDefault(); + $("#next-step-and").html(""); var entity = $('#suggest').val(); var condition = $('#condition').val(); var value = $('#value').val(); @@ -329,22 +336,42 @@ $('#rule-submit').click('', function(e) { url: "/ajax_form.php", data: $('form.alerts-form').serialize(), success: function(msg){ - $("#message").html('
'+msg+'
'); - $("#create-alert").modal('hide'); if(msg.indexOf("ERROR:") <= -1) { + $("#message").html('
'+msg+'
'); + $("#create-alert").modal('hide'); $('#response').data('tagmanager').empty(); setTimeout(function() { location.reload(1); }, 1000); + } else { + $('#ajax_response').html('
'+msg+'
'); } }, error: function(){ - $("#message").html('
An error occurred creating this alert.
'); - $("#create-alert").modal('hide'); + $("#ajax_response").html('
An error occurred creating this alert.
'); } }); }); +$( "#suggest, #value" ).blur(function() { + var $this = $(this); + var suggest = $('#suggest').val(); + var value = $('#value').val(); + if (suggest == "") { + $("#next-step-and").html(""); + $("#value").closest('.form-group').removeClass('has-error'); + $("#suggest").closest('.form-group').addClass('has-error'); + } else if (value == "") { + $("#next-step-and").html(""); + $("#value").closest('.form-group').addClass('has-error'); + $("#suggest").closest('.form-group').removeClass('has-error'); + } else { + $("#suggest").closest('.form-group').removeClass('has-error'); + $("#value").closest('.form-group').removeClass('has-error'); + $("#next-step-and").html(' Click AND / OR'); + } +}); +