diff --git a/AUTHORS.md b/AUTHORS.md index 826311481..230f379a4 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -71,4 +71,5 @@ Contributors to LibreNMS: - Tony Murray (murrant) - Peter Lamperud (vizay) - Louis Bailleul (alucardfh) +- Rick Hodger (Tatermen) [1]: http://observium.org/ "Observium web site" diff --git a/includes/discovery/entity-physical.inc.php b/includes/discovery/entity-physical.inc.php index 812be65ff..caacb5be2 100644 --- a/includes/discovery/entity-physical.inc.php +++ b/includes/discovery/entity-physical.inc.php @@ -37,6 +37,9 @@ if ($config['enable_inventory']) { $entPhysicalIsFRU = $entry['jnxFruType']; $entPhysicalAlias = $entry['entPhysicalAlias']; $entPhysicalAssetID = $entry['entPhysicalAssetID']; + // fix for issue 1865, $entPhysicalIndex, as it contains a quad dotted number on newer Junipers + // using str_replace to remove all dots should fix this even if it changes in future + $entPhysicalIndex = str_replace('.','',$entPhysicalIndex); } else { $entPhysicalDescr = $entry['entPhysicalDescr']; @@ -127,18 +130,7 @@ if ($config['enable_inventory']) { echo '+'; }//end if - if ($device['os'] == 'junos') { - // $entPhysicalIndex appears as a numeric OID fragment - // (string), so convert it to an "integer" for the - // validation step below since it is stored in the DB as - // an integer. This should be fixed. - list($first,$second) = explode('.', $entPhysicalIndex); - $entPhysicalIndexNoDots = $first.$second; - $valid[$entPhysicalIndexNoDots] = 1; - } - else { - $valid[$entPhysicalIndex] = 1; - } + $valid[$entPhysicalIndex] = 1; }//end if }//end foreach }