diff --git a/html/includes/print-interface-adsl.inc.php b/html/includes/print-interface-adsl.inc.php index f2d2e0900..43ecfa97a 100644 --- a/html/includes/print-interface-adsl.inc.php +++ b/html/includes/print-interface-adsl.inc.php @@ -1,6 +1,6 @@ 0 || $interface['ifOutErrors_delta'] > 0) { $error_img = generate_port_link($interface,"Interface Errors","port_errors"); -} else { $error_img = ""; } +} else { + $error_img = ""; +} -# FIXME leading slash - does javascript honor base tag? echo(" +onclick=\"location.href='device/".$device['device_id']."/port/".$interface['interface_id']."/'\" style='cursor: pointer;'> "); echo(" " . generate_port_link($interface, $interface['ifIndex'] . ". ".$interface['label']) . " @@ -30,17 +31,15 @@ unset ($break); if ($port_details) { $ipdata = mysql_query("SELECT * FROM `ipv4_addresses` WHERE `interface_id` = '" . $interface['interface_id'] . "'"); - while ($ip = mysql_fetch_Array($ipdata)) + while ($ip = mysql_fetch_assoc($ipdata)) { - # FIXME leading slash - does javascript honor base tag? - echo("$break $ip[ipv4_address]/$ip[ipv4_prefixlen]"); + echo("$break ".$ip['ipv4_address']."/".$ip['ipv4_prefixlen'].""); $break = ","; } $ip6data = mysql_query("SELECT * FROM `ipv6_addresses` WHERE `interface_id` = '" . $interface['interface_id'] . "'"); - while ($ip6 = mysql_fetch_Array($ip6data)) + while ($ip6 = mysql_fetch_assoc($ip6data)) { - # FIXME leading slash - does javascript honor base tag? - echo("$break ".Net_IPv6::compress($ip6['ipv6_address'])."/".$ip6['ipv6_prefixlen'].""); + echo("$break ".Net_IPv6::compress($ip6['ipv6_address'])."/".$ip6['ipv6_prefixlen'].""); $break = ","; } } @@ -141,7 +140,6 @@ if ($graph_type && is_file($graph_file)) onmouseout=\"return nd();\"> "); echo(""); - } ?> \ No newline at end of file diff --git a/html/pages/device/edit/device.inc.php b/html/pages/device/edit/device.inc.php index 967896806..f426c4f0b 100644 --- a/html/pages/device/edit/device.inc.php +++ b/html/pages/device/edit/device.inc.php @@ -87,15 +87,16 @@ if ($updated && $update_message)