From 2734cd327e0a25e8e58c06537393a5260d485ddd Mon Sep 17 00:00:00 2001
From: laf <neil@lathwood.co.uk>
Date: Mon, 14 Dec 2015 22:01:01 +0000
Subject: [PATCH] Updated userlevel access on settings page

---
 html/pages/settings.inc.php | 70 ++++++++++++++++++-------------------
 1 file changed, 35 insertions(+), 35 deletions(-)

diff --git a/html/pages/settings.inc.php b/html/pages/settings.inc.php
index 1271e8d22..27efd4f1d 100644
--- a/html/pages/settings.inc.php
+++ b/html/pages/settings.inc.php
@@ -53,31 +53,32 @@ echo $pagetitle[0];
 
 <?php
 
-if (isset($vars['sub'])) {
+if (is_admin() === true) {
+    if (isset($vars['sub'])) {
+
+        if (file_exists("pages/settings/".mres($vars['sub']).".inc.php")) {
+            require_once "pages/settings/".mres($vars['sub']).".inc.php";
+        }
+        else {
+            print_error("This settings page doesn't exist, please go to the main settings page");
+        }
 
-    if (file_exists("pages/settings/".mres($vars['sub']).".inc.php")) {
-        require_once "pages/settings/".mres($vars['sub']).".inc.php";
     }
     else {
-        print_error("This settings page doesn't exist, please go to the main settings page");
-    }
-
-}
-else {
 
 ?>
 
 <div class="container-fluid">
     <div class="row">
 <?php
-    foreach (dbFetchRows("SELECT `config_group` FROM `config` GROUP BY `config_group`") as $sub_page) {
-        $sub_page = $sub_page['config_group'];
+        foreach (dbFetchRows("SELECT `config_group` FROM `config` GROUP BY `config_group`") as $sub_page) {
+            $sub_page = $sub_page['config_group'];
 ?>
         <div class="col-lg-2 col-md-2 col-sm-2 col-xs-2">
             <a class="btn btn-primary" href="<?php echo(generate_url(array('page'=>'settings','sub'=>$sub_page))); ?>"><?php echo ucfirst($sub_page); ?> Settings</a>
         </div>
 <?php
-    }
+        }
 ?>
     </div>
 </div>
@@ -90,33 +91,32 @@ else {
  * @return string
  */
 
-    function a2t($a) {
-        $r = "<table class='table table-condensed table-hover'><tbody>";
-        foreach( $a as $k=>$v ) {
-            if( !empty($v) ) {
-                $r .= "<tr><td class='col-md-2'><i><b>".$k."</b></i></td><td class='col-md-10'>".(is_array($v)?a2t($v):"<code>".wordwrap($v,75,"<br/>")."</code>")."</td></tr>";
+        function a2t($a) {
+            $r = "<table class='table table-condensed table-hover'><tbody>";
+            foreach( $a as $k=>$v ) {
+                if( !empty($v) ) {
+                    $r .= "<tr><td class='col-md-2'><i><b>".$k."</b></i></td><td class='col-md-10'>".(is_array($v)?a2t($v):"<code>".wordwrap($v,75,"<br/>")."</code>")."</td></tr>";
+                }
+            }
+            $r .= '</tbody></table>';
+            return $r;
+        }
+        echo "<div class='table-responsive'>".a2t($config)."</div>";
+
+        if ($_SESSION['userlevel'] >= '10') {
+
+            if ($debug) {
+                echo("<pre>");
+                print_r($config);
+                echo("</pre>");
             }
         }
-        $r .= '</tbody></table>';
-        return $r;
-    }
-    if( $_SESSION['userlevel'] >= 10 ) {
-        echo "<div class='table-responsive'>".a2t($config)."</div>";
-    }
-    else {
-        include 'includes/error-no-perm.inc.php';
-    }
-
-    if ($_SESSION['userlevel'] >= '10') {
-
-        if ($debug) {
-            echo("<pre>");
-            print_r($config);
-            echo("</pre>");
+        else {
+            include 'includes/error-no-perm.inc.php';
         }
     }
-    else {
-        include 'includes/error-no-perm.inc.php';
-    }
+}
+else {
+    include 'includes/error-no-perm.inc.php';
 }
 ?>