From f491ec6580d99897c9e2a55125fead77d4717aeb Mon Sep 17 00:00:00 2001
From: Tom Laermans <tom@localhost>
Date: Sat, 14 Apr 2012 23:28:23 +0000
Subject: [PATCH] cleanups, add epson printer discovery, fix bar colour on
 device overview for unknown toner colours

git-svn-id: http://www.observium.org/svn/observer/trunk@3036 61d68cd4-352d-0410-923a-c4978735b2b8
---
 html/images/os/epson.png                  | Bin 0 -> 1611 bytes
 html/includes/functions.inc.php           |  12 ++++++------
 html/includes/graphs/device/toner.inc.php |  18 +++++++++---------
 html/includes/graphs/toner/usage.inc.php  |   4 ++--
 html/pages/device/overview/toner.inc.php  |   9 +--------
 includes/discovery/os/epson.inc.php       |   8 ++++++++
 includes/polling/bgp-peers.inc.php        |  10 ++--------
 includes/polling/wifi.inc.php             |   4 ++--
 includes/static-config.php                |   8 ++++++++
 9 files changed, 38 insertions(+), 35 deletions(-)
 create mode 100644 html/images/os/epson.png
 create mode 100644 includes/discovery/os/epson.inc.php

diff --git a/html/images/os/epson.png b/html/images/os/epson.png
new file mode 100644
index 0000000000000000000000000000000000000000..746fdc0513585873436eebfeb9fc8761c435daaa
GIT binary patch
literal 1611
zcmds0`BPH|5Pm2YDpf&XtWs$(LlvV*5D~d7kwd6*XsF;3Y*20_DI|bVRH85-6i3m5
zB~Xgc5d(-L_oX05s}RsYRFVinNE!k!gb)I}<h?#-{1^I5zuj+l_S@OnUv{&D0*-80
zzimAL02};#y-uJRvr6N&X!I(-)r%$^!#kAWnHWK3#LyBj!7&#j02U2n?}(w&6EXXU
z_WLkIdl#aEi=!h3N3<srtEhRq(J>>2pTD<}$Z+Ep<Lw(e7qF=GCEfQ_5&)Q(t<vDy
zg>!dM(J+eSPXd6aw@q}^bpWsy2s#$*y$Kh;X%B59F3}7Zw;302j;C1?;w%aA7Wjm(
z@zG{`>1KGkIi7AxNVRgHS?#B7aY)`wyu8(sxy_NW{Q%S2iSdmS>s#j(%)ulZXT}Z}
zCe}3t>z0glPqB4Pv~^?daAn!JrP;V&v2jn^`8{i|Cv%qv%kJ<sJI||oz0(LjR|q~=
zF^8`2@?!7yzKJ_>i+F@>?|Z}1Kl5N<rb}SvfuKCs<Jr#S+iv76QphcjlfRHo=X+5K
zeJT0J!VAce_sKEE!Lbj1j4eEMk#jV%f*e<RCaE%v!9B~YqA;r|%o-}Al*;(yd~#V7
z>tO`z&+yd8QLM^H)|1#YZrt^1+KsB8Z&oE`)G#x+X?ahQvTBpFpQhdExSm&?ey5s!
zuOYLbG3(d5tiorxoc8>(wt|X|lE=^4_g~zr=;m-ci@9CJRh=c(ot*0KlInr-+U|$7
z{grjSmGynxx;}0*?@8-GMZ^1=HhyhOe{CzTw(V_w*GLC%>?Kds!~57fG}g%*@8Qc{
z^Cw>qPYwvC1_aW9chW(DWKb|Q_(9S)ta|faIy5SMJ1XUirugES5utooG(9Yy84|07
z6Engo@S_AAlYm0WoLDw5Qz$3oYKeSqO0ggTHBxX<It$5WSER~i83@Th-886Hfa+<b
zMy_0*RxZg@%Q6)rRU>kh{-1exRt<q_Xhx-*(ICnt9k_(dX`uOqC6!h`r$y!$;RP+U
zsD)HZ$UKCoA!K10Sy+J=R}hU3(ZI-}9?|OHMHtb-$T9>&kbX&rEW-$-M^?}X!#W+T
zgJJ!uBYFhZBM7Q}t`Jm4fuIH>XyY@{yZujbD*uKlx?r4fB7lsp{67O|e7Ly;01UW(
zUZmjE(eq7#05R8MofA0r{Icv&R@a(@vft=NycUxRnkcHtKw#3FLfvC}NsABe94Km3
zikeeZyxAfr<+=7`h19*2)R-V{yCf6T7kL;5)5AZpZA}{RVYL^K3=^YiMRHh6Q+tDa
zJY$0uA?)naIN_ztBJ)D$_Xj5}LO<B%%ZeUVM*GW0?pfAzWLQV2DmGTNC(~7*OHl|C
zPQD5)?kmPOMCOn?iYH6FeU4kV!F~Jp75sjo$syYg<5os?)}~@Z9%NBNHQ#-@n<JYT
zXg_;1mhp@rGPE<!&Yk7Ic{ZMMXum^G`c9wH>8@r&@?dGSm3}5iyA=!w=d>w@%zB1i
zNy*uZmp8RGpN6c(RLdFbrXMIo#jCVTq50PC2+7^@B>Y&*FqRhoI^-jU8d>T-B2+RA
zj*ea|bxLWhYhd=v!&ov<lY_&pkK(iv8y_+B88LhUC+6H2UrnF!phFWq!Y#Blp0J?e
zXh8z|ucCJz=}Z%gpsYf`2&B~cHopWUB2xAXE7Nr;v={uB+kF?r8PV+qWlEcgBzpPZ
b=^+5%Q)VtV3KaFP{(zr%fLG1opV<Eb{3WKR

literal 0
HcmV?d00001

diff --git a/html/includes/functions.inc.php b/html/includes/functions.inc.php
index edebda817..20215f7d5 100644
--- a/html/includes/functions.inc.php
+++ b/html/includes/functions.inc.php
@@ -1,16 +1,16 @@
 <?php
 
-function toner2colour($descr)
+function toner2colour($descr, $percent)
 {
-  $colour = NULL;
+  $colour = get_percentage_colours(100-$percent);
 
-  if (substr($descr,-1) == 'C' || stripos($descr,"cyan"   ) !== false) { $colour = "55D6D3"; }
-  if (substr($descr,-1) == 'M' || stripos($descr,"magenta") !== false) { $colour = "F24AC8"; }
+  if (substr($descr,-1) == 'C' || stripos($descr,"cyan"   ) !== false) { $colour['left'] = "55D6D3"; $colour['right'] = "33B4B1"; }
+  if (substr($descr,-1) == 'M' || stripos($descr,"magenta") !== false) { $colour['left'] = "F24AC8"; $colour['right'] = "D028A6"; }
   if (substr($descr,-1) == 'Y' || stripos($descr,"yellow" ) !== false
                                || stripos($descr,"giallo" ) !== false
-                               || stripos($descr,"gul"    ) !== false) { $colour = "FFF200"; }
+                               || stripos($descr,"gul"    ) !== false) { $colour['left'] = "FFF200"; $colour['right'] = "DDD000"; }
   if (substr($descr,-1) == 'K' || stripos($descr,"black"  ) !== false
-                               || stripos($descr,"nero"   ) !== false) { $colour = "000000"; }
+                               || stripos($descr,"nero"   ) !== false) { $colour['left'] = "000000"; $colour['right'] = "222222"; }
 
   return $colour;       
 }
diff --git a/html/includes/graphs/device/toner.inc.php b/html/includes/graphs/device/toner.inc.php
index 2781448d5..110689635 100644
--- a/html/includes/graphs/device/toner.inc.php
+++ b/html/includes/graphs/device/toner.inc.php
@@ -12,32 +12,32 @@ foreach (dbFetchRows("SELECT * FROM toner where device_id = ?", array($id)) as $
 {
   $colour = toner2colour($toner['toner_descr']);
 
-  if ($colour == NULL) 
+  if ($colour['left'] == NULL) 
   {
     # FIXME generic colour function
     switch ($iter)
     {
       case "1":
-        $colour= "000000";
+        $colour['left']= "000000";
         break;
       case "2":
-        $colour= "008C00";
+        $colour['left']= "008C00";
         break;
       case "3":
-        $colour= "4096EE";
+        $colour['left']= "4096EE";
         break;
       case "4":
-        $colour= "73880A";
+        $colour['left']= "73880A";
         break;
       case "5":
-        $colour= "D01F3C";
+        $colour['left']= "D01F3C";
         break;
       case "6":
-        $colour= "36393D";
+        $colour['left']= "36393D";
         break;
       case "7":
       default:
-        $colour= "FF0000";
+        $colour['left']= "FF0000";
         unset($iter);
         break;
     }
@@ -50,7 +50,7 @@ foreach (dbFetchRows("SELECT * FROM toner where device_id = ?", array($id)) as $
   $toner_id = $toner['toner_id'];
 
   $rrd_options .= " DEF:toner$toner_id=$rrd_filename:toner:AVERAGE";
-  $rrd_options .= " LINE2:toner$toner_id#".$colour.":'" . $descr . "'";
+  $rrd_options .= " LINE2:toner$toner_id#".$colour['left'].":'" . $descr . "'";
   $rrd_options .= " GPRINT:toner$toner_id:LAST:'%5.0lf%%'";
   $rrd_options .= " GPRINT:toner$toner_id:MIN:'%5.0lf%%'";
   $rrd_options .= " GPRINT:toner$toner_id:MAX:%5.0lf%%\\\\l";
diff --git a/html/includes/graphs/toner/usage.inc.php b/html/includes/graphs/toner/usage.inc.php
index fd6e989f7..3849b279c 100755
--- a/html/includes/graphs/toner/usage.inc.php
+++ b/html/includes/graphs/toner/usage.inc.php
@@ -7,7 +7,7 @@ include("includes/graphs/common.inc.php");
 $rrd_options .= " COMMENT:'                                 Cur    Max\\n'";
 
 $colour = toner2colour($toner['toner_descr']);
-if ($colour == NULL) { $colour="CC0000"; }
+if ($colour['left'] == NULL) { $colour['left']="CC0000"; }
 
 $descr = substr(str_pad($toner['toner_descr'],26),0,26);
 
@@ -15,7 +15,7 @@ $background = get_percentage_colours(100-$toner['toner_current']);
 
 $rrd_options .= " DEF:toner" . $toner['toner_id'] . "=".$rrd_filename.":toner:AVERAGE ";
 
-$rrd_options .= " LINE1:toner" . $toner['toner_id'] . "#" . $colour . ":'" . $descr . "' ";
+$rrd_options .= " LINE1:toner" . $toner['toner_id'] . "#" . $colour['left'] . ":'" . $descr . "' ";
 
 $rrd_options .= " AREA:toner" . $toner['toner_id' ] . "#" . $background['right'] . ":";
 $rrd_options .= " GPRINT:toner" . $toner['toner_id'] . ":LAST:'%5.0lf%%'";
diff --git a/html/pages/device/overview/toner.inc.php b/html/pages/device/overview/toner.inc.php
index 22c8c2a19..92fa9aa37 100644
--- a/html/pages/device/overview/toner.inc.php
+++ b/html/pages/device/overview/toner.inc.php
@@ -19,14 +19,7 @@ if (count($toners))
     $free = formatStorage($toner['toner_free']);
     $used = formatStorage($toner['toner_used']);
 
-    $background['left'] = toner2colour($toner['toner_descr']);
-    unset($background['right']);
-    for ($i = 0;$i < strlen($background['left']); $i++)
-    {
-      $new = dechex(hexdec("0x" . $background['left'][$i])+1);
-      if (strlen($new) != 1) { $new = 'F'; }
-      $background['right'] .= $new;
-    }
+    $background = toner2colour($toner['toner_descr'], $percent);
     
     $graph_array           = array();
     $graph_array['height'] = "100";
diff --git a/includes/discovery/os/epson.inc.php b/includes/discovery/os/epson.inc.php
new file mode 100644
index 000000000..1369bdbf8
--- /dev/null
+++ b/includes/discovery/os/epson.inc.php
@@ -0,0 +1,8 @@
+<?php
+
+if (!$os)
+{
+  if (strstr($sysDescr, "EPSON Built-in")) { $os = "epson"; }
+}
+
+?>
\ No newline at end of file
diff --git a/includes/polling/bgp-peers.inc.php b/includes/polling/bgp-peers.inc.php
index 6586726fb..24e4685c8 100755
--- a/includes/polling/bgp-peers.inc.php
+++ b/includes/polling/bgp-peers.inc.php
@@ -2,21 +2,15 @@
 
 ## We should walk, so we can discover here too.
 
-echo("Polling BGP peers\n");
-
 global $debug;
 
-if (!$config['enable_bgp'])
-{
-  echo("BGP Support Disabled\n");
-}
-else
+if ($config['enable_bgp'])
 {
   foreach (dbFetchRows("SELECT * FROM bgpPeers WHERE device_id = ?", array($device['device_id'])) as $peer)
   {
     ### Poll BGP Peer
 
-    echo("Checking ".$peer['bgpPeerIdentifier']." ");
+    echo("Checking BGP peer ".$peer['bgpPeerIdentifier']." ");
 
     if (!strstr($peer['bgpPeerIdentifier'],':'))
     {
diff --git a/includes/polling/wifi.inc.php b/includes/polling/wifi.inc.php
index 3e9da04a5..87e051873 100644
--- a/includes/polling/wifi.inc.php
+++ b/includes/polling/wifi.inc.php
@@ -1,9 +1,9 @@
 <?php
 
-echo("Wireless: ");
-
 if ($device['type'] == 'network' || $device['type'] == 'firewall')
 {
+  echo("Wireless: ");
+
   ##### GENERIC FRAMEWORK, FILLING VARIABLES
   if ($device['os'] == 'airport')
   {
diff --git a/includes/static-config.php b/includes/static-config.php
index 52a126a43..db337d20a 100644
--- a/includes/static-config.php
+++ b/includes/static-config.php
@@ -739,6 +739,14 @@ $config['os'][$os]['icon']              = "ricoh";
 $config['os'][$os]['over'][0]['graph']  = "device_toner";
 $config['os'][$os]['over'][0]['text']   = "Toner";
 
+$os = "epson";
+$config['os'][$os]['group']             = "printer";
+$config['os'][$os]['text']              = "Epson Printer";
+$config['os'][$os]['type']              = "printer";
+$config['os'][$os]['icon']              = "epson";
+$config['os'][$os]['over'][0]['graph']  = "device_toner";
+$config['os'][$os]['over'][0]['text']   = "Toner";
+
 $os = "xerox";
 $config['os'][$os]['group']             = "printer";
 $config['os'][$os]['text']              = "Xerox Printer";