Commit Graph
55434 Commits
Author SHA1 Message Date
89ba882b08 runtime-metadata sanity test: ignore pre-release and build identifier (#85198)
* Ignore pre-release and build identifier.

* Add tests.

* Improve changelog fragment.

Co-authored-by: Matt Clay <matt@mystile.com>

* Extend tests.

---------

Co-authored-by: Matt Clay <matt@mystile.com>
2025-11-10 09:16:54 -08:00
6a4b199054 Remove decrypt arg-docs mismatch (#86128)
* Remove decrypt arg-docs mismatch

Removes the use of the arg in the action plugin
and removes the associated doc fragment. Changes
no behavior because the lack of decrypt in the
argspec prevents a value being passed in and
the args.get('decrypt', True) means that it is
always true.

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2025-11-07 10:54:25 -05:00
Matt ClayandGitHub 4184d9665e Fix getuser fallback error handling (#86144) 2025-11-07 01:57:23 +00:00
707a5ec617 Add CLAUDE.md/AGENTS.md files for tighter assistance with GenAIs (#85841)
* Add an override of the `/review` slash command in claude code
* Add support for `CLAUDE.local.md` and `~/.claude/ansible.md`

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
2025-11-06 15:08:54 -06:00
e3cff24134 Increase code coverage of utils/encrypt.py (#86060)
* Add encryption code coverage

Co-authored-by: Matt Clay <matt@mystile.com>
2025-11-06 15:26:41 -05:00
Matt ClayandGitHub a4ae978122 template module - Report syntax error line number (#86101)
Report the line number for Jinja syntax errors in template files.
2025-11-05 17:11:17 -08:00
Matt ClayandGitHub 8ac5c8580b Remove urllib2 pylint check (#86139)
No supported Python version provides urllib2.
2025-11-06 00:55:32 +00:00
Matt ClayandGitHub 5b8ae0b5b5 Fix deprecation comments (#86138) 2025-11-06 00:53:41 +00:00
Martin KrizekandGitHub a2dda41bb6 Removed deprecated handle_stats_and_callbacks param of _load_included_file (#86063)
* Removed deprecated handle_stats_and_callbacks param of _load_included_file

Fixes #86003

* ci_complete
2025-11-05 13:25:49 -05:00
IksasandGitHub 388ce79fcd apt: Stop the >= operator from being ignored while installing packages (#85254)
* apt: Stop the >= operator from being ignored if packages are not already installed

* apt: Fix failing integration test in Ubuntu 24.04
2025-11-04 15:34:08 -08:00
3c3a06b8fd inventory: Add warning for invalid priority values (#86114)
* Handle ValueError raised when user set invalid priority values
* Update tests to work with Pytest

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Mannu Silva <wise.tent4987@fastmail.com>
2025-11-04 10:52:15 -05:00
Martin KrizekandGitHub f743dfce93 basic.py: add proper deprecations (#86064)
* basic.py: add proper deprecations

* fix sanity
2025-11-04 10:19:15 -05:00
55e4ba224d Raise min setuptools and remove wheel from build (#86040)
* Raise min setuptools for license specifier

Raises the minimum setuptools version used for our build requirements to
support the new license identifiers. This removes a deprecation warning
emitted by setuptools and will avoid breaking the build when the old
format is eventually removed.

* Fix typos referencing PEP 639 in text

The respective metadata docs are
* https://packaging.python.org/en/latest/specifications/pyproject-toml/#license
* https://packaging.python.org/en/latest/specifications/core-metadata/#license-expression

---------

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
2025-11-04 03:33:31 +00:00
829373bfb9 Use json for test inventory - ci_complete (#86118)
* Use json for test inventory - ci_complete

Uses the JSON/YAML format for the inventory files generated by
`ansible-test`. This solves minor issues with using complex values when
building the test inventory files like backslashes or more complex data
structures.

* Apply suggestions from code review

Co-authored-by: Matt Clay <matt@mystile.com>

* Add changelog and use more limited ext config var - ci_complete

---------

Co-authored-by: Matt Clay <matt@mystile.com>
2025-11-04 13:25:03 +10:00
3c5bb535a9 Fix incorrect propagation of task.connection (#86121)
Co-authored-by: Matt Clay <matt@mystile.com>
2025-11-03 21:17:43 +00:00
Brian CocaandGitHub 5904846342 config lookup, remove unreachable code (#86051)
defensive, but uneeded since get_option already precludes bad values
this far in
2025-11-03 10:35:08 -05:00
730af3239d 🧪 Set timeouts for CI jobs
Sometimes, AZP would mark steps in jobs as cancelled when they've
actually exited successfully but on the boundary of the default
60-minute timeout. Such logs might be difficult to reason about.

Additionally, `entry-point.sh` sets a 60-minute timeout for the main
test invocation but it would never trigger earlier that AZP would kill
such a job as the job-global timeout was 60 minutes already and it'd
always be hit earlier than the test runner one.

The patch sets maximum observable job timeouts with extra buffer to
account for flakiness.

PR #86073

Co-authored-by: Matt Clay <matt@mystile.com>
2025-10-30 16:48:46 +01:00
Matt ClayandGitHub 13496b9e11 ansible-test - Fix integration test code coverage (#86100) 2025-10-29 18:21:53 -07:00
Shion IchikawaandGitHub f2a4d6de12 🚨 fix yaml syntax error on ./test/integration/targets/unarchive/tasks/test_missing_binaries.yml (#86099) 2025-10-29 22:55:26 +00:00
Martin KrizekandGitHub 2e8a859477 Remove deprecated imports from basic.py (#86065)
Fixes #85997
2025-10-29 19:53:03 +01:00
Matt ClayandGitHub bb30a7fa1f ansible-test - Update base/default containers (#86087) 2025-10-28 14:01:37 -07:00
Matt ClayandGitHub 3bf54c8128 Remove obsolete incidental_ios_file test (#86086) 2025-10-28 10:44:36 -07:00
Matt ClayandGitHub 12acd5c18f ansible-test - Update sanity requirements (#86083) 2025-10-28 09:33:10 -07:00
Jason K HallandGitHub 8d07ed6318 Handle ValueError in run_command when parsing invalid args(shlex.split) (#85945) 2025-10-27 14:02:22 -07:00
Brian CocaandGitHub d9d11d6ff6 sanitize path symbols in inventory_hostname on file cache plugins (#41420)
* File based cache plugins filenames fix

File based cache plugins will now correctly handle inventory_hostnames
with 'path symbols' in their names. This should allow those using
chroot and jail connection plugins to use file based caches now.
2025-10-24 14:57:11 -04:00
Abhijeet KasurdeandGitHub 7bd2475a70 file, stat: return disk_usage_bytes (#85909)
Fixes: #70834

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-24 18:42:58 +00:00
Brian CocaandGitHub 169e6bead3 generated inventory plugin, add extra vars option (#85372) 2025-10-24 07:39:07 -04:00
Brian CocaandGitHub 516a114ef6 option deprecations show alternatives (#86032)
Give users a helpful hint on what to do to address the deprecation
2025-10-23 12:44:43 -04:00
Sloane HertelandGitHub 68f5a7ca1c Update issue templates with suggestion to exclude Galaxy server secrets and general reminder (#85481) 2025-10-23 14:53:45 +00:00
Patrick KingstonandGitHub 087931546d Remove deprecated safe_eval (#86019)
* Remove safe_eval from codebase

Resolves deprecations in 85996 and 85999

* Remove deprecations from sanity ignores

* Add changelog fragment

* Add newline to file

* Remove unused imports
2025-10-22 12:22:14 -04:00
Sloane HertelandGitHub df34bf9e70 Update win_exec_wrapper integration test to match #86029 (#86052)
* Remove assertion now that there is no warning
2025-10-21 17:56:18 -04:00
sivel / Matt MartzandGitHub e4b4787c02 Soft deprecate ansible.module_utils.six (#86048) 2025-10-21 16:20:55 -05:00
Martin KrizekandGitHub 6dd48814f2 Remove test/units/module_utils/compat/test_datetime.py (#86045)
Follow up on #86018
2025-10-21 14:17:47 -04:00
Abhijeet KasurdeandGitHub ef53d63953 package_facts: typecast bytes to string while returning facts (#85939)
Fixes: #85937

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 15:46:00 +00:00
Abhijeet KasurdeandGitHub 367de4498b module_utils: remove deprecated compat.datetime APIs (#86018)
Fixes: #86000

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:43:28 -04:00
Abhijeet KasurdeandGitHub 9a350ff104 git: removed deprecated gpg_whitelist alias (#86011)
Fixes: #86004

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:37:42 -04:00
Abhijeet KasurdeandGitHub 9f1177a056 Removed parameter 'required' from get_bin_path API (#86009)
Fixes: #85998

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:37:03 -04:00
Abhijeet KasurdeandGitHub 790b66f383 interpreter_discovery: removed auto_silent* option (#86006)
* interpreter_discovery: removed auto_silent* option

* Removed deprecated auto_silent* option from interpreter_discovery_python

Fixes: #85995

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Make CI green

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Make CI green I

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

---------

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:35:53 -04:00
Jason K HallandGitHub 192948434c galaxy: handle missing 'results' key in cached Galaxy API responses. (#85972)
* galaxy: handle missing 'results' key in cached Galaxy API responses.

* galaxy: clarified AnsibleError message for missing cache results.

* Modified AnsibleError message and added a regression test.

* Fixed formatting issue in test/units/galaxy/test_api.py

* Added a changelog entry.

* Modified changelog.
2025-10-21 11:27:24 -04:00
sivel / Matt MartzandGitHub d6051b18dd Add support for crypt/libxcrypt via ctypes, as an alternative to passlib (#85970)
* Add support for crypt/libxcrypt via ctypes, as an alternative to passlib

* move verbosity message to BaseHash

* Don't require DYLD_LIBRARY_PATH mods for standard homebrew installs on macos

* improve crypt_gensalt error handling
2025-10-21 11:24:57 -04:00
f1f5b934c2 Update DataLoader to deal almost exclusively in str (#85941)
* Update DataLoader to deal almost exclusively in str

* source can be None as well

Co-authored-by: David Shrewsbury <Shrews@users.noreply.github.com>
2025-10-21 11:06:15 -04:00
Miro HrončokandGitHub 719681bbe2 Do not require wheel for building (#85533)
* Do not require wheel for building

- current version of setuptools (70.1+) does not need wheel at all
- older versions of setuptools would fetch wheel when building wheels (but not sdists)

* Pin setuptools to a version not requiring wheel

Now when we don't list wheel,
we are unable to pin it to a particular version.

Instead, use setuptools version that no longer uses it.
2025-10-21 01:35:19 +00:00
ccfb7b1364 Fix include_role error consitency and add rescueable option (#86012)
* include_role now behaves more like task on error

changes _from errors from syntax to task failures, by default
which makes it more consistent with other existing errors
 * also force 'missing role' to behave as syntax error when false
 * also error when subdir does not exist, previouslly we ignored missing
   file
 * add 'rescuable' toggle to allow user to chose error type

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
2025-10-20 19:19:11 -04:00
1cb2932c95 config lookup, fix 'show_origin' and variables (#85356)
show_origin and variable sources were broken for base config when 'forked' from plugins
---------
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
2025-10-20 19:15:00 -04:00
Jordan BoreanandGitHub 99bb587906 Remove AddType warning for cleanup (#86029)
Removes the warning emitted when using Add-Type and the cleanup of temp
files fails due to a file still being in use. The cleanup should be
handled by AnsibleModule on exit giving it more time to wait for any
open file handles to close. The exception is still present if calling
`Add-CSharpType` without an `AnsibleModule` object.
2025-10-21 06:35:31 +10:00
22721b5d63 Slurp armor option (#85986)
* slurp, add option to deactivate the armor

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2025-10-17 18:09:30 -04:00
823c117563 Fix dry-run for notifications @ publish-codecov
Apparently `codecovcli send-notifications` does not have a `--dry-run`
CLI option. This patch stops adding it to the command and implements
an external `dry-run` mode in the wrapper script or this case instead.

This is a follow-up for #85968.

Co-authored-by: Matt Clay <matt@mystile.com>
2025-10-16 23:28:14 +02:00
sivel / Matt MartzandGitHub 1a3e63c794 Don't deprecate six yet (#86020) 2025-10-16 12:56:23 -05:00
🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)andGitHub 2799a684fc Explicitly notify Codecov about upload completion (#85968)
This patch add an additional invocation of Codecov CLI that tells the
backend that we're done uploading. It is supposed to stop Codecov from
guessing whether to wait for more uploads for the CI or start
processing them already.

Upstream refs:
* https://docs.codecov.com/docs/cli-options#send-notifications
* https://docs.codecov.com/docs/notifications#preventing-notifications-until-youre-ready-to-send-notifications
* https://docs.codecov.com/docs/codecovyml-reference#codecovnotifymanual_trigger
* https://github.com/codecov/codecov-cli/pull/195 (https://github.com/getsentry/prevent-cli/commit/d634ebd8f21d2880df12f002d83afa499652ea25)
* https://github.com/codecov/codecov-action/issues/1436
* https://github.com/codecov/engineering-team/issues/107
* https://github.com/codecov/roadmap/issues/20
* https://github.com/codecov/feedback/discussions/204#discussioncomment-8796433
* https://github.com/codecov/engineering-team/issues/1245
* https://github.com/codecov/engineering-team/issues/3
* https://github.com/codecov/worker/pull/14 (https://github.com/codecov/umbrella/commit/71626b6368a880d92f1d611917e6ec08598ef26b)
2025-10-15 08:50:25 -07:00
Martin KrizekandGitHub 05d5b0f168 Avoid the ssh-agent exiting before tests end (#85979)
There were couple of occurrences where the hard 30 seconds limit on
running ssh-agent was not enough for the test to run and the ssh-agent
was killed resulting in the test failing with "Connection refused". This
change just lets the agent run in the background and kills it
manually after the tests finish.
2025-10-15 08:23:31 +02:00