Sloane Hertel and GitHub
3a42a00368
Targeted fix for installing roles with symlinks containing '..' ( #82165 )
...
Set the tarfile attribute to a normalized value from unfrackpath instead
of validating path parts and omiting potentially invald parts
Allow tarfile paths/links containing '..', '$', '~' as long as the
normalized realpath is in the tarfile's role directory
2023-11-30 18:05:48 -05:00
Yigithan Kadir BALCI and GitHub
b405958f79
fixes typo in cli/ansible-pull arguments ( #82316 )
2023-11-30 14:13:39 -05:00
1dd0d6fad7
remote log info ( #81711 )
...
Both posix and powershell avenues updated to allow for customized string logging on remote
Co-authored-by: Jordan Borean <jborean93@gmail.com >
2023-11-30 13:12:55 -05:00
Matt Clay
4208bdbbcd
ansible-test - Update nios-test-container to 3.0.0
2023-11-30 09:59:49 -08:00
Jan-Piet Mens and GitHub
ee86dafc6e
Amend doc of name= parameter to indicate a list of packages can be used ( #82309 )
...
* Amend doc of name= parameter to indicate a list of packages can be used
One of the examples here shows package installing a list of packages, but the name= parameter did not reflect this possibility.
* add dependency to underlying package manager
2023-11-30 11:09:35 -05:00
Brian Coca and GitHub
e80507af32
fact_gathering improve linux thread counts ( #82261 )
...
don't use `//` aka `floor()` as some architectures show counts of 1.9 threads per CPU and market as 2 per CPU, `round()` will be closer to that.
2023-11-28 10:49:52 -05:00
Martin Krizek and GitHub
fd2d0ecfb7
Remove unneeded Task.is_static assignment ( #82288 )
...
Added in b38f746 but there is/was no Task.is_static so this just creates
a new attribute dynamically that is/was never used.
2023-11-28 10:35:31 -05:00
Suryakiran Sureshkumar and GitHub
322eb0f884
changed the salt type from int to string ( #82274 )
2023-11-28 10:23:39 -05:00
Abhijeet Kasurde and GitHub
265f5e724c
apt_repository: Do not convert symlink repo to a normal file ( #82271 )
...
* apt_repository: Do not convert symlink repo to a normal file
* module manually writes to repo files. If the file is a symlink
module used to re-write and convert a symlink to a normal file.
This fix tracks the symlink and keeps the changes intact.
Fixes : #49809
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-28 10:20:57 -05:00
Abhijeet Kasurde and GitHub
e6e19e37f7
validate-modules: Check for correct values in choice ( #82266 )
...
* validate-modules: Check for correct values in choice
* validate-modules test now checks the length of choices and
correct option values inside the choice.
Fixes : #82179
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
* Fix sanity tests
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
---------
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-28 10:09:29 -05:00
Greg "Gwmngilfen" Sutcliffe and GitHub
0806da55b1
Add DCO and update CONTRIBUTING.md ( #82105 )
2023-11-27 10:19:37 -08:00
Felix Fontein and GitHub
479949aad2
Fix broken docs RST reference. ( #82286 )
2023-11-27 10:02:20 -05:00
Martin Krizek and GitHub
afd45aca6a
ansible-test - remove rhel 9.2 test remote ( #82211 )
...
Fixes #82024
2023-11-27 10:03:42 +01:00
e0bf76e3db
Issue #80267 : Remove user not found warning ( #80291 )
...
Co-authored-by: Sebi94nbg <sebastian.kraetzig@4g-server.eu >
2023-11-23 15:25:35 +01:00
Martin Krizek and GitHub
d664f13b4a
Allow include_tasks handlers for searching role subdirs ( #82248 )
...
Fixes #82241
2023-11-22 17:42:51 +01:00
Chris Francy and GitHub
a4b00793be
Update known_hosts module to better handle @cert-authority keys ( #70340 )
...
Signed-off-by: Chris Francy <zoredache@gmail.com >
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-21 16:55:01 -08:00
Gods and GitHub
7dde4901d4
unarchive: support 8 character permission strings ( #81705 )
2023-11-21 16:48:31 -08:00
Abhijeet Kasurde and GitHub
ce9d268ab8
unarchive: force unarchive if the symlink target changes ( #82253 )
...
Fixes : #30420
Original PR from nrwahl2 (https://github.com/ansible/ansible/pull/30463 )
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-21 09:11:23 -08:00
Herman van Rink and GitHub
d6a8df3218
csvfile - add a keycol parameter to specify in which column to search. ( #82242 )
2023-11-21 10:40:31 -05:00
0a6779f6b7
docs: improve readability & scope of docs for ansible.builtin.assert ( #82256 )
...
Co-authored-by: Jonathan Biegert <jonathan.biegert@sva.de >
2023-11-21 10:24:07 -05:00
Martin Krizek and GitHub
c35e0e8fd8
Re-enable "group removal" integration test for dnf5 ( #82250 )
...
Fixed in https://github.com/rpm-software-management/dnf5/pull/1013
2023-11-21 10:19:28 -05:00
Abhijeet Kasurde and GitHub
fbdb666411
ansible-test: Added Fedora 39 ( #82218 )
...
* Fedora 39 remote
* Fedora 39 container
Fixes : #82018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-17 02:30:13 +00:00
Abhijeet Kasurde and GitHub
8fd1aa0d2e
syslog: Handle ValueError raised while sending logs to syslog ( #82225 )
...
* ValueError exception is raised when Null Character is sent
to syslog.syslog with Python 3.12.
* Handle this error gracefully instead of stacktrace
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-16 21:15:08 +00:00
Abhijeet Kasurde and GitHub
1a759659fe
Enable vendored copy of distutils in entry_point test ( #82232 )
...
* Enable use of vendored copy of distutils by removing
the environment variable SETUPTOOLS_USE_DISTUTILS
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-16 12:21:19 -08:00
Brian Coca and GitHub
8b102dca4a
wait_for, fallback to read for non mmapable files ( #82064 )
...
* also handle oserror, added debug jic
2023-11-16 15:20:52 -05:00
Brian Coca and GitHub
f6d7dd0840
displaly. log, handle when caplevel is already taken care of ( #82227 )
...
reneables ansible logging
2023-11-16 19:49:40 +00:00
Abhijeet Kasurde and GitHub
f8cdec6324
ansible-test: Downgrade containerd for Fedora 39 ( #82231 )
...
* containerd 1.6.23 on Fedora 39 causes issue. Downgrading
to containered to 1.6.19-2 works.
* See: https://bugzilla.redhat.com/show_bug.cgi?id=2237396
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-16 19:18:18 +00:00
Abhijeet Kasurde and GitHub
a45dc10b8f
ansible-test: Skip modularity test for Fedora 39 and up ( #82230 )
...
* Modularity is deprecated in Fedora 39 and onwards,
Skip modularity tests
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-16 19:14:07 +00:00
Brian Coca and GitHub
6e448edc63
no_log avoid masking booleans ( #82217 )
...
* no_log avoid masking booleans
* clog
* fix issues
2023-11-17 05:04:34 +10:00
Matt Martz and GitHub
f42984eeb3
Fix ManifestControl dataclass to work with future annotations ( #82215 )
...
* Fix ManifestControl dataclass to work with future annotations
* Add tests
2023-11-17 05:02:58 +10:00
Brian Coca and GitHub
3d9e5c8b9d
fix pc misuse ( #82157 )
...
use the more up to date 'task' as play_context only has the 'initial' values.
2023-11-16 09:30:18 -05:00
e2d108db2b
log verbosity ( #81692 )
...
Allow users to adjust verbosity to logs at same or higher level than to callback/screen
Co-authored-by: Matt Clay <matt@mystile.com >
2023-11-15 20:57:59 -05:00
dbddabce9e
Create prefix of file using ansible.builtin.tempfile ( #82209 )
...
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-15 10:43:10 -08:00
Brian Coca and GitHub
8825e60add
ansible-pull: expand destinantion directoy to avoid purgin in / ( #82030 )
...
* expand destinantion directoy to avoid purgin in /
bad things could happen and help alone is not enough
2023-11-15 10:09:04 -05:00
05259aa6ce
Restart a Service with Sleep Between Stop and Start ( #82210 )
...
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-14 19:40:48 -08:00
Martin Krizek and GitHub
0bab08ee33
ansible-test - Add RHEL 9.3 support ( #82178 )
...
Fixes #82020
2023-11-14 08:23:44 +01:00
Brian Coca and GitHub
2277d470b3
fix typo ( #82202 )
2023-11-13 14:59:07 -05:00
4a84a9b3db
copy keep suffix on temp file for validation ( #82158 )
...
Also updated test to require suffix
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com >
2023-11-13 10:03:58 -05:00
Martin Krizek and GitHub
a8b6ef7e7c
flush_handlers: handle a failure in a nested block with force_handlers ( #81572 )
...
Fixes #81532
ci_complete
2023-11-13 09:57:43 +01:00
Ikko Eltociear Ashimine and GitHub
9c09ed7392
Fix typo in validation.py ( #82195 )
...
covert -> convert
2023-11-12 06:54:53 -08:00
Tom Downes and GitHub
667526c22f
Fix two misspellings of occurred ( #82159 )
2023-11-08 13:50:08 -08:00
Dellucifer and GitHub
f2b5c33349
fixed typos in the documentation ( #82077 )
2023-11-08 11:54:48 -08:00
Matt Clay
fd009a073a
Remove sefcontext support plugin
...
It was only used by the subversion test, but is no longer required.
2023-11-07 17:45:13 -08:00
Matt Clay and GitHub
0e6942a4d7
Remove unused unit test code ( #82168 )
2023-11-07 15:59:08 -08:00
Abhijeet Kasurde and Matt Clay
c5b68ef16d
Update Python3
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-07 15:43:31 -08:00
Matt Clay
98407fc00e
Remove unused validate-modules unit test code
2023-11-07 13:43:11 -08:00
Matt Clay and GitHub
dae4e2f07f
Remove unused/unreachable unit test code ( #82160 )
2023-11-07 12:41:42 -08:00
Matt Clay and GitHub
0be33551d7
Remove unit tests dependent on systemd bindings ( #82161 )
...
These do no not run as part of our test suite.
2023-11-07 12:41:16 -08:00
Abhijeet Kasurde and Matt Clay
78c16d983e
Remove type_regex testcase
...
This is leftover testcase for type checker regex removed in
https://github.com/ansible/ansible/pull/82153
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2023-11-07 12:39:08 -08:00
Matt Clay
9dd3eafa14
ansible-test - Use pylint unidiomatic-typecheck
...
This replaces the regex based check previously used within the validate-modules sanity test.
NOTE: The pylint check overlaps with a similar check for pep8.
Both are used, since the pep8 based check is more nuanced than the one in pylint.
For example, allowing `is` checks, but not `==` comparisons.
If the pylint check is ignored, the pep8 check would still be relevant.
2023-11-07 11:04:22 -08:00