mirror of
https://github.com/ansible/ansible.git
synced 2026-07-29 16:35:20 +02:00
Matt DavisandGitHub
a287389124
Fix network module failures on tagged RPC responses * Zap tags in networking JsonRpcServer before pickling responses. * Verify with unit test - suboptimal, but avoids a fake network connection plugin.
32 lines
941 B
Python
32 lines
941 B
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import pickle
|
|
|
|
from ansible._internal._datatag._tags import Origin
|
|
from ansible.utils.jsonrpc import JsonRpcServer
|
|
|
|
|
|
def test_response_type_cleansing() -> None:
|
|
"""Avoid unpickling errors in module contexts by ensuring that non-scalar JsonRpc responses are not pickled with tags."""
|
|
|
|
class RPCTest:
|
|
def returns_list_with_tagged_str(self) -> list:
|
|
return [Origin(description="blar").tag("taggedstr")]
|
|
|
|
s = JsonRpcServer()
|
|
s.register(RPCTest())
|
|
req = dict(method="returns_list_with_tagged_str", id=1, params=(tuple(), {}))
|
|
jsonrpc_res = s.handle_request(json.dumps(req))
|
|
|
|
deserialized_res = json.loads(jsonrpc_res)
|
|
|
|
pickled_res = deserialized_res.get("result")
|
|
|
|
assert pickled_res is not None
|
|
|
|
res = pickle.loads(pickled_res.encode(errors="surrogateescape"))
|
|
|
|
assert res == ["taggedstr"]
|
|
assert not Origin.is_tagged_on(res[0])
|