From 0e2b0643a95799cc45be8e730628efae79cf3883 Mon Sep 17 00:00:00 2001 From: Will Greenberg Date: Thu, 30 Apr 2026 13:32:57 -0700 Subject: [PATCH] certbot: demote manual's preference for dns-persist-01 This'll avoid breaking things for users relying on http-01's most-preferred status. --- certbot/src/certbot/_internal/plugins/manual.py | 2 +- certbot/src/certbot/_internal/tests/plugins/manual_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/certbot/src/certbot/_internal/plugins/manual.py b/certbot/src/certbot/_internal/plugins/manual.py index 9af898438..1e05c8da4 100644 --- a/certbot/src/certbot/_internal/plugins/manual.py +++ b/certbot/src/certbot/_internal/plugins/manual.py @@ -171,7 +171,7 @@ permitted by DNS standards.) def get_chall_pref(self, identifier: str) -> Iterable[type[challenges.Challenge]]: # pylint: disable=unused-argument,missing-function-docstring - return [challenges.DNSPersist01, challenges.HTTP01, challenges.DNS01] + return [challenges.HTTP01, challenges.DNS01, challenges.DNSPersist01] def perform(self, achalls: list[achallenges.AnnotatedChallenge] ) -> list[challenges.ChallengeResponse]: # pylint: disable=missing-function-docstring diff --git a/certbot/src/certbot/_internal/tests/plugins/manual_test.py b/certbot/src/certbot/_internal/tests/plugins/manual_test.py index ed263e5dc..8af9cbf0c 100644 --- a/certbot/src/certbot/_internal/tests/plugins/manual_test.py +++ b/certbot/src/certbot/_internal/tests/plugins/manual_test.py @@ -74,7 +74,7 @@ class AuthenticatorTest(test_util.TempDirTestCase): def test_get_chall_pref(self): assert self.auth.get_chall_pref('example.org') == \ - [challenges.DNSPersist01, challenges.HTTP01, challenges.DNS01] + [challenges.HTTP01, challenges.DNS01, challenges.DNSPersist01] def test_script_perform(self): self.config.manual_auth_hook = (