starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-04 08:03:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove use of sha1 (#4271)

Browse Source 
These are not security critical uses of sha1 but they should still be removed.
This commit is contained in:
Blake Griffith
2017-03-02 21:16:19 -08:00
committed by Jacob Hoffman-Andrews
parent 93908a33bc
commit 12a6e49cf1
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
acme/acme/challenges.py
+1 -1
View File
@@ -445,7 +445,7 @@ class TLSSNI01Response(KeyAuthorizationChallengeResponse):
""" """
# pylint: disable=protected-access # pylint: disable=protected-access
sans = crypto_util._pyopenssl_cert_or_req_san(cert) sans = crypto_util._pyopenssl_cert_or_req_san(cert)
logger.debug('Certificate %s. SANs: %s', cert.digest('sha1'), sans) logger.debug('Certificate %s. SANs: %s', cert.digest('sha256'), sans)
return self.z_domain.decode() in sans return self.z_domain.decode() in sans
def simple_verify(self, chall, domain, account_public_key, def simple_verify(self, chall, domain, account_public_key,
certbot/tests/crypto_util_test.py
+2 -2
View File
@@ -336,8 +336,8 @@ class CertLoaderTest(unittest.TestCase):
from certbot.crypto_util import pyopenssl_load_certificate from certbot.crypto_util import pyopenssl_load_certificate
cert, file_type = pyopenssl_load_certificate(CERT) cert, file_type = pyopenssl_load_certificate(CERT)
self.assertEqual(cert.digest('sha1'), self.assertEqual(cert.digest('sha256'),
OpenSSL.crypto.load_certificate(file_type, CERT).digest('sha1')) OpenSSL.crypto.load_certificate(file_type, CERT).digest('sha256'))
def test_load_invalid_cert(self): def test_load_invalid_cert(self):
from certbot.crypto_util import pyopenssl_load_certificate from certbot.crypto_util import pyopenssl_load_certificate