starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-03 00:22:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

add two notes

Browse Source
This commit is contained in:
Seth Schoen
2012-06-01 00:05:10 -07:00
parent 4e93c24e49
commit 1b6ffaecc2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
webserver/CSR.py
+6
View File
@@ -79,6 +79,9 @@ def can_sign(name):
def verify(key, data): def verify(key, data):
"""What string was validly signed by this public key? (or None)""" """What string was validly signed by this public key? (or None)"""
# Note: Only relatively short strings will work, so we normally
# sign a hash of the signed data rather than signing the signed
# data directly.
with tempfile.NamedTemporaryFile() as tmp: with tempfile.NamedTemporaryFile() as tmp:
tmp.write(key) tmp.write(key)
tmp.flush() tmp.flush()
@@ -99,4 +102,7 @@ def sign(key, data):
def issue(csr): def issue(csr):
"""Issue the certificate requested by this CSR and return it!""" """Issue the certificate requested by this CSR and return it!"""
# TODO: a real CA should severely restrict the content of the cert, not
# just grant what's asked for. (For example, the CA shouldn't trust
# all the data in the subject field if it hasn't been validated.)
return "-----BEGIN CERTIFICATE-----\nThanks for the shrubbery!\n-----END CERTIFICATE-----" return "-----BEGIN CERTIFICATE-----\nThanks for the shrubbery!\n-----END CERTIFICATE-----"