starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-02 16:12:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Install pipstrap to pin setuptools/pip/wheels, since setuptools and pip continues to play with us. (#23)

Browse Source 
So, setuptools broke the installation setup, by removing a deprecated API that is still used by some of our dependencies (see pypa/setuptools#2017)

This PR fixes the Docker build by using pipstrap to pin pip/setuptools/wheels, like it is done in several critical places (certbot-auto, ...).

An issue in certbot is opened to fix more generally the problem in most recent versions of setuptools: certbot/certbot#7976

It rebuilt locally all dockers (certbot + dns plugins) for the three architectures, and all have passed.
This commit is contained in:
Adrien Ferrand
2020-05-05 17:10:51 -07:00
committed by GitHub
parent 361d1f732e
commit 3a997a5631
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/docker/core/Dockerfile
+2
View File
@@ -21,6 +21,7 @@ RUN mkdir -p src \
&& tar xf certbot-${CERTBOT_VERSION}.tar.gz \ && tar xf certbot-${CERTBOT_VERSION}.tar.gz \
&& cp certbot-${CERTBOT_VERSION}/CHANGELOG.md certbot-${CERTBOT_VERSION}/README.rst src/ \ && cp certbot-${CERTBOT_VERSION}/CHANGELOG.md certbot-${CERTBOT_VERSION}/README.rst src/ \
&& cp certbot-${CERTBOT_VERSION}/letsencrypt-auto-source/pieces/dependency-requirements.txt . \ && cp certbot-${CERTBOT_VERSION}/letsencrypt-auto-source/pieces/dependency-requirements.txt . \
&& cp certbot-${CERTBOT_VERSION}/letsencrypt-auto-source/pieces/pipstrap.py . \
&& cp -r certbot-${CERTBOT_VERSION}/tools tools \ && cp -r certbot-${CERTBOT_VERSION}/tools tools \
&& cp -r certbot-${CERTBOT_VERSION}/acme src/acme \ && cp -r certbot-${CERTBOT_VERSION}/acme src/acme \
&& cp -r certbot-${CERTBOT_VERSION}/certbot src/certbot \ && cp -r certbot-${CERTBOT_VERSION}/certbot src/certbot \
@@ -45,6 +46,7 @@ RUN apk add --no-cache --virtual .build-deps \
openssl-dev \ openssl-dev \
musl-dev \ musl-dev \
libffi-dev \ libffi-dev \
&& python pipstrap.py \
&& pip install -r dependency-requirements.txt \ && pip install -r dependency-requirements.txt \
&& pip install --no-cache-dir --no-deps \ && pip install --no-cache-dir --no-deps \
--editable src/acme \ --editable src/acme \