Completely deprecate certbot-auto (#8489)

Fixes #8296

* Completely deprecate certbot-auto

* Add changelog

certbot/CHANGELOG.md

@@ -10,7 +10,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
 
 ### Changed
 
-*
+* certbot-auto was deprecated on all systems.
 
 ### Fixed
 

letsencrypt-auto-source/letsencrypt-auto

@@ -804,6 +804,7 @@ elif [ -f /etc/mageia-release ]; then
   # Mageia has both /etc/mageia-release and /etc/redhat-release
   DEPRECATED_OS=1
 elif [ -f /etc/redhat-release ]; then
+  DEPRECATED_OS=1
   # Run DeterminePythonVersion to decide on the basis of available Python versions
   # whether to use 2.x or 3.x on RedHat-like systems.
   # Then, revert LE_PYTHON to its previous state.
@@ -836,12 +837,7 @@ elif [ -f /etc/redhat-release ]; then
       INTERACTIVE_BOOTSTRAP=1
     fi
 
-    Bootstrap() {
-      BootstrapMessage "Legacy RedHat-based OSes that will use Python3"
-      BootstrapRpmPython3Legacy
-    }
     USE_PYTHON_3=1
-    BOOTSTRAP_VERSION="BootstrapRpmPython3Legacy $BOOTSTRAP_RPM_PYTHON3_LEGACY_VERSION"
 
     # Try now to enable SCL rh-python36 for systems already bootstrapped
     # NB: EnablePython36SCL has been defined along with BootstrapRpmPython3Legacy in certbot-auto
@@ -860,18 +856,7 @@ elif [ -f /etc/redhat-release ]; then
     fi
 
     if [ "$RPM_USE_PYTHON_3" = 1 ]; then
-      Bootstrap() {
-        BootstrapMessage "RedHat-based OSes that will use Python3"
-        BootstrapRpmPython3
-      }
       USE_PYTHON_3=1
-      BOOTSTRAP_VERSION="BootstrapRpmPython3 $BOOTSTRAP_RPM_PYTHON3_VERSION"
-    else
-      Bootstrap() {
-        BootstrapMessage "RedHat-based OSes"
-        BootstrapRpmCommon
-      }
-      BOOTSTRAP_VERSION="BootstrapRpmCommon $BOOTSTRAP_RPM_COMMON_VERSION"
     fi
   fi
 
@@ -889,10 +874,7 @@ elif uname | grep -iq FreeBSD ; then
 elif uname | grep -iq Darwin ; then
   DEPRECATED_OS=1
 elif [ -f /etc/issue ] && grep -iq "Amazon Linux" /etc/issue ; then
-  Bootstrap() {
+  DEPRECATED_OS=1
-    ExperimentalBootstrap "Amazon Linux" BootstrapRpmCommon
-  }
-  BOOTSTRAP_VERSION="BootstrapRpmCommon $BOOTSTRAP_RPM_COMMON_VERSION"
 elif [ -f /etc/product ] && grep -q "Joyent Instance" /etc/product ; then
   DEPRECATED_OS=1
 else

letsencrypt-auto-source/letsencrypt-auto.template

@@ -326,6 +326,7 @@ elif [ -f /etc/mageia-release ]; then
   # Mageia has both /etc/mageia-release and /etc/redhat-release
   DEPRECATED_OS=1
 elif [ -f /etc/redhat-release ]; then
+  DEPRECATED_OS=1
   # Run DeterminePythonVersion to decide on the basis of available Python versions
   # whether to use 2.x or 3.x on RedHat-like systems.
   # Then, revert LE_PYTHON to its previous state.
@@ -358,12 +359,7 @@ elif [ -f /etc/redhat-release ]; then
       INTERACTIVE_BOOTSTRAP=1
     fi
 
-    Bootstrap() {
-      BootstrapMessage "Legacy RedHat-based OSes that will use Python3"
-      BootstrapRpmPython3Legacy
-    }
     USE_PYTHON_3=1
-    BOOTSTRAP_VERSION="BootstrapRpmPython3Legacy $BOOTSTRAP_RPM_PYTHON3_LEGACY_VERSION"
 
     # Try now to enable SCL rh-python36 for systems already bootstrapped
     # NB: EnablePython36SCL has been defined along with BootstrapRpmPython3Legacy in certbot-auto
@@ -382,18 +378,7 @@ elif [ -f /etc/redhat-release ]; then
     fi
 
     if [ "$RPM_USE_PYTHON_3" = 1 ]; then
-      Bootstrap() {
-        BootstrapMessage "RedHat-based OSes that will use Python3"
-        BootstrapRpmPython3
-      }
       USE_PYTHON_3=1
-      BOOTSTRAP_VERSION="BootstrapRpmPython3 $BOOTSTRAP_RPM_PYTHON3_VERSION"
-    else
-      Bootstrap() {
-        BootstrapMessage "RedHat-based OSes"
-        BootstrapRpmCommon
-      }
-      BOOTSTRAP_VERSION="BootstrapRpmCommon $BOOTSTRAP_RPM_COMMON_VERSION"
     fi
   fi
 
@@ -411,10 +396,7 @@ elif uname | grep -iq FreeBSD ; then
 elif uname | grep -iq Darwin ; then
   DEPRECATED_OS=1
 elif [ -f /etc/issue ] && grep -iq "Amazon Linux" /etc/issue ; then
-  Bootstrap() {
+  DEPRECATED_OS=1
-    ExperimentalBootstrap "Amazon Linux" BootstrapRpmCommon
-  }
-  BOOTSTRAP_VERSION="BootstrapRpmCommon $BOOTSTRAP_RPM_COMMON_VERSION"
 elif [ -f /etc/product ] && grep -q "Joyent Instance" /etc/product ; then
   DEPRECATED_OS=1
 else

tests/letstest/scripts/test_leauto_upgrades.sh

@@ -105,15 +105,10 @@ if ./letsencrypt-auto -v --debug --version | grep "WARNING: couldn't find Python
     exit 1
 fi
 
-# On systems like Debian where certbot-auto is deprecated, we expect it to
+# Since certbot-auto is deprecated, we expect it to leave existing Certbot
-# leave existing Certbot installations unmodified so we check for the same
+# installations unmodified so we check for the same version that was initially
-# version that was initially installed below.  Once certbot-auto is deprecated
+# installed below.
-# on RHEL systems, we can unconditionally check for INITIAL_VERSION.
+EXPECTED_VERSION="$INITIAL_VERSION"
-if [ -f /etc/debian_version ]; then
-    EXPECTED_VERSION="$INITIAL_VERSION"
-else
-    EXPECTED_VERSION=$(grep -m1 LE_AUTO_VERSION certbot-auto | cut -d\" -f2)
-fi
 
 if ! /opt/eff.org/certbot/venv/bin/letsencrypt --version 2>&1 | tail -n1 | grep "^certbot $EXPECTED_VERSION$" ; then
     echo unexpected certbot version found
@@ -124,22 +119,3 @@ if ! diff letsencrypt-auto letsencrypt-auto-source/letsencrypt-auto ; then
     echo letsencrypt-auto and letsencrypt-auto-source/letsencrypt-auto differ
     exit 1
 fi
-
-if [ "$RUN_RHEL6_TESTS" = 1 ]; then
-    # Add the SCL python release to PATH in order to resolve python3 command
-    PATH="/opt/rh/rh-python36/root/usr/bin:$PATH"
-    if ! command -v python3; then
-        echo "Python3 wasn't properly installed"
-        exit 1
-    fi
-    if [ "$(/opt/eff.org/certbot/venv/bin/python -V 2>&1 | cut -d" " -f 2 | cut -d. -f1)" != 3 ]; then
-        echo "Python3 wasn't used in venv!"
-        exit 1
-    fi
-
-    if [ "$("$PYTHON_NAME" tools/readlink.py $OLD_VENV_PATH)" != "/opt/eff.org/certbot/venv" ]; then
-        echo symlink from old venv path not properly created!
-        exit 1
-    fi
-fi
-echo upgrade appeared to be successful

tests/letstest/scripts/test_letsencrypt_auto_certonly_standalone.sh

@@ -16,58 +16,14 @@ sudo chown root "$LE_AUTO_PATH"
 sudo chmod 0755 "$LE_AUTO_PATH"
 export PATH="$LE_AUTO_DIR:$PATH"
 
-# On systems like Debian where certbot-auto is deprecated, we expect
+# Since certbot-auto is deprecated, we expect certbot-auto to error and
-# certbot-auto to error and refuse to install Certbot.  Once certbot-auto is
+# refuse to install Certbot.
-# deprecated on RHEL systems, we can unconditionally run this code.
+set +o pipefail
-if [ -f /etc/debian_version ]; then
+if ! letsencrypt-auto --debug --version | grep "Certbot cannot be installed."; then
-    set +o pipefail
+    echo "letsencrypt-auto didn't report being uninstallable."
-    if ! letsencrypt-auto --debug --version | grep "Certbot cannot be installed."; then
-        echo "letsencrypt-auto didn't report being uninstallable."
-        exit 1
-    fi
-    if [ ${PIPESTATUS[0]} != 1 ]; then
-        echo "letsencrypt-auto didn't exit with status 1 as expected"
-        exit 1
-    fi
-    # letsencrypt-auto is deprecated and cannot be installed on this system so
-    # we cannot run the rest of this test.
-    exit 0
-fi
-
-letsencrypt-auto --os-packages-only --debug --version
-
-# This script sets the environment variables PYTHON_NAME, VENV_PATH, and
-# VENV_SCRIPT based on the version of Python available on the system. For
-# instance, Fedora uses Python 3 and Python 2 is not installed.
-. tests/letstest/scripts/set_python_envvars.sh
-
-# Create a venv-like layout at the old virtual environment path to test that a
-# symlink is properly created when letsencrypt-auto runs.
-HOME=${HOME:-~root}
-XDG_DATA_HOME=${XDG_DATA_HOME:-~/.local/share}
-OLD_VENV_BIN="$XDG_DATA_HOME/letsencrypt/bin"
-mkdir -p "$OLD_VENV_BIN"
-touch "$OLD_VENV_BIN/letsencrypt"
-
-letsencrypt-auto certonly --no-self-upgrade -v --standalone --debug \
-                   --text --agree-tos \
-                   --renew-by-default --redirect \
-                   --register-unsafely-without-email \
-                   --domain $PUBLIC_HOSTNAME --server $BOULDER_URL
-
-LINK_PATH=$("$PYTHON_NAME" tools/readlink.py ${XDG_DATA_HOME:-~/.local/share}/letsencrypt)
-if [ "$LINK_PATH" != "/opt/eff.org/certbot/venv" ]; then
-    echo symlink from old venv path not properly created!
     exit 1
 fi
-
+if [ ${PIPESTATUS[0]} != 1 ]; then
-if ! letsencrypt-auto --help --no-self-upgrade | grep -F "letsencrypt-auto [SUBCOMMAND]"; then
+    echo "letsencrypt-auto didn't exit with status 1 as expected"
-    echo "letsencrypt-auto not included in help output!"
-    exit 1
-fi
-
-OUTPUT_LEN=$(letsencrypt-auto --install-only --no-self-upgrade --quiet 2>&1 | wc -c)
-if [ "$OUTPUT_LEN" != 0 ]; then
-    echo letsencrypt-auto produced unexpected output!
     exit 1
 fi