starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-02 00:22:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix unit tests on Windows (#7270)

Browse Source 
Fixes #6850

This PR makes the last corrections needed to run all unit tests on Windows:

add a function to check if a hook is executable in a cross-platform compatible way
handle correctly the PATH surgery for Windows during hook execution
handle correctly an account compatibility over both ACMEv1 and ACMEv2
remove (finally!) the @broken_on_windows decorator.

* Fix account_tests

* Fix hook executable test

* Remove the temporary decorator @broken_on_windows

* Fix util_test

* No broken unit test on Windows anymore

* More elegant mock

* Fix context manager

* Adapt coverage

* Corrections

* Adapt coverage

* Forbid os.access
This commit is contained in:
Adrien Ferrand
2019-08-01 10:39:46 -07:00
committed by Brad Warren
parent 2d3f3a042a
commit 56f609d4f5
15 changed files with 163 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.codecov.yml
+1 -1
View File
@@ -13,6 +13,6 @@ coverage:
flags: windows
# Fixed target instead of auto set by #7173, can
# be removed when flags in Codecov are added back.
target: 97.2
target: 97.6
threshold: 0.1
base: auto