starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 00:35:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove wheel hack in windows installer construction script (#8752)

Browse Source 
In #8649 we added some code to trick pynsist and make it understand that `abi3` wheels for Windows are forward compatible, meaning that the cryptography wheel tagged `cp36-abi3` is in fact compatible with Python 3.6+, and not only Python 3.6.

Since pynsist 2.7 the tool now understand `abi3` wheels properly, and this trick is not needed anymore.

Please note that despite modifying the pynsist pinning in `dev_constraints.txt`, it will have no effect since pynsist currently escape the pinning system. This is handled in https://github.com/certbot/certbot/pull/8749.
This commit is contained in:
Adrien Ferrand
2021-04-02 10:37:19 -07:00
committed by GitHub
parent fea0b4e2e5
commit 8a84c88fee
2 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/dev_constraints.txt
+2 -2
View File
@@ -83,10 +83,10 @@ PyGithub==1.52
Pygments==2.2.0
pyjwt==1.7.1
pylint==2.4.3
pynacl==1.3.0
# If pynsist version is upgraded, our NSIS template windows-installer/template.nsi
# must be upgraded if necessary using the new built-in one from pynsist.
pynacl==1.3.0
pynsist==2.6
pynsist==2.7
pytest==3.2.5
pytest-cov==2.5.1
pytest-forked==0.2