starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 16:19:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

When in doubt, use the config root

Browse Source
This commit is contained in:
Brad Warren
2016-01-26 11:40:44 -08:00
parent 90c7a73146
commit 8ba59406ad
2 changed files with 2 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
letsencrypt-apache/letsencrypt_apache/parser.py
+1 -18
View File
@@ -597,7 +597,7 @@ class ApacheParser(object):
.. todo:: Make sure that files are included .. todo:: Make sure that files are included
""" """
default = self._set_user_config_file() default = self.loc["root"]
temp = os.path.join(self.root, "ports.conf") temp = os.path.join(self.root, "ports.conf")
if os.path.isfile(temp): if os.path.isfile(temp):
@@ -618,23 +618,6 @@ class ApacheParser(object):
raise errors.NoInstallationError("Could not find configuration root") raise errors.NoInstallationError("Could not find configuration root")
def _set_user_config_file(self):
"""Set the appropriate user configuration file
.. todo:: This will have to be updated for other distros versions
:param str root: pathname which contains the user config
"""
# Basic check to see if httpd.conf exists and
# in hierarchy via direct include
# httpd.conf was very common as a user file in Apache 2.2
if (os.path.isfile(os.path.join(self.root, "httpd.conf")) and
self.find_dir("Include", "httpd.conf", self.loc["root"])):
return os.path.join(self.root, "httpd.conf")
else:
return os.path.join(self.root, "apache2.conf")
def case_i(string): def case_i(string):
"""Returns case insensitive regex. """Returns case insensitive regex.
letsencrypt-apache/letsencrypt_apache/tests/parser_test.py
+1 -11
View File
@@ -106,7 +106,7 @@ class BasicParserTest(util.ParserTest):
def test_set_locations(self): def test_set_locations(self):
with mock.patch("letsencrypt_apache.parser.os.path") as mock_path: with mock.patch("letsencrypt_apache.parser.os.path") as mock_path:
mock_path.isfile.side_effect = [True, False, False] mock_path.isfile.side_effect = [False, False]
# pylint: disable=protected-access # pylint: disable=protected-access
results = self.parser._set_locations() results = self.parser._set_locations()
@@ -114,16 +114,6 @@ class BasicParserTest(util.ParserTest):
self.assertEqual(results["default"], results["listen"]) self.assertEqual(results["default"], results["listen"])
self.assertEqual(results["default"], results["name"]) self.assertEqual(results["default"], results["name"])
def test_set_user_config_file(self):
# pylint: disable=protected-access
path = os.path.join(self.parser.root, "httpd.conf")
open(path, 'w').close()
self.parser.add_dir(self.parser.loc["default"], "Include",
"httpd.conf")
self.assertEqual(
path, self.parser._set_user_config_file())
@mock.patch("letsencrypt_apache.parser.ApacheParser._get_runtime_cfg") @mock.patch("letsencrypt_apache.parser.ApacheParser._get_runtime_cfg")
def test_update_runtime_variables(self, mock_cfg): def test_update_runtime_variables(self, mock_cfg):
mock_cfg.return_value = ( mock_cfg.return_value = (