OMerge branch 'master' into fix_plugin_prepare

letsencrypt/renewer.py

@@ -169,11 +169,6 @@ def main(config=None, args=sys.argv[1:]):
             # user about the existence of an invalid or corrupt renewal
             # config rather than simply ignoring it.
             continue
-        if cert.should_autodeploy():
-            cert.update_all_links_to(cert.latest_common_version())
-            # TODO: restart web server (invoke IInstaller.restart() method)
-            notify.notify("Autodeployed a cert!!!", "root", "It worked!")
-            # TODO: explain what happened
         if cert.should_autorenew():
             # Note: not cert.current_version() because the basis for
             # the renewal is the latest version, even if it hasn't been
@@ -182,3 +177,8 @@ def main(config=None, args=sys.argv[1:]):
             renew(cert, old_version)
             notify.notify("Autorenewed a cert!!!", "root", "It worked!")
             # TODO: explain what happened
+        if cert.should_autodeploy():
+            cert.update_all_links_to(cert.latest_common_version())
+            # TODO: restart web server (invoke IInstaller.restart() method)
+            notify.notify("Autodeployed a cert!!!", "root", "It worked!")
+            # TODO: explain what happened

tests/boulder-integration.sh

@@ -1,7 +1,14 @@
 #!/bin/sh -xe
-# Simple integration test, make sure to activate virtualenv beforehand
+# Simple integration test. Make sure to activate virtualenv beforehand
 # (source venv/bin/activate) and that you are running Boulder test
 # instance (see ./boulder-start.sh).
+#
+# Environment variables:
+#   SERVER: Passed as "letsencrypt --server" argument. Boulder
+#           monolithic defaults to :4000, AMQP defaults to :4300. This
+#           script defaults to monolithic.
+#
+# Note: this script is called by Boulder integration test suite!
 
 root="$(mktemp -d)"
 echo "\nRoot integration tests directory: $root"
@@ -11,7 +18,7 @@ store_flags="$store_flags --logs-dir $root/logs"
 common() {
     # first three flags required, rest is handy defaults
     letsencrypt \
-        --server http://localhost:4000/acme/new-reg \
+        --server "${SERVER:-http://localhost:4000/acme/new-reg}" \
         --no-verify-ssl \
         --dvsni-port 5001 \
         $store_flags \
@@ -44,5 +51,5 @@ for x in cert chain fullchain privkey;
 do
     latest="$(ls -1t $dir/ | grep -e "^${x}" | head -n1)"
     live="$(readlink -f "$root/conf/live/le.wtf/${x}.pem")"
-    #[ "${dir}/${latest}" = "$live" ]  # renewer fails this test
+    [ "${dir}/${latest}" = "$live" ]
 done