mirror of
https://github.com/certbot/certbot.git
synced 2026-08-01 16:19:13 +02:00
Do not call updaters and deployers when run with --dry-run (#6038)
When Certbot is run with --dry-run, skip running GenericUpdater and RenewDeployer interface methods. This PR also makes the parameter order of updater.run_generic_updaters and updater.run_renewal_deployer consistent. Fixes #5927 * Do not call updaters and deployers when run with --dry-run * Use ConfigTestCase instead of mocking config objects manually
This commit is contained in:
committed by
Brad Warren
parent
e48c653245
commit
9f6b147d6f
+2
-2
@@ -431,8 +431,8 @@ def handle_renewal_request(config):
|
||||
renew_skipped.append("%s expires on %s" % (renewal_candidate.fullchain,
|
||||
expiry.strftime("%Y-%m-%d")))
|
||||
# Run updater interface methods
|
||||
updater.run_generic_updaters(lineage_config, plugins,
|
||||
renewal_candidate)
|
||||
updater.run_generic_updaters(lineage_config, renewal_candidate,
|
||||
plugins)
|
||||
|
||||
except Exception as e: # pylint: disable=broad-except
|
||||
# obtain_cert (presumably) encountered an unanticipated problem.
|
||||
|
||||
Reference in New Issue
Block a user