starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-02 00:22:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

logging: log timestamps as local timezone instead of UTC (#5607)

Browse Source 
* logging: log timestamps as local timezone instead of UTC

* test(logging): expect localtime instead of gmtime

* linter fix in logging
This commit is contained in:
sydneyli
2018-03-21 15:41:33 -07:00
committed by Brad Warren
parent afb6260c34
commit bca0aa48c2
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
certbot/log.py
-2
View File
@@ -19,7 +19,6 @@ import logging.handlers
import os import os
import sys import sys
import tempfile import tempfile
import time
import traceback import traceback
from acme import messages from acme import messages
@@ -148,7 +147,6 @@ def setup_log_file_handler(config, logfile, fmt):
handler.doRollover() # TODO: creates empty letsencrypt.log.1 file handler.doRollover() # TODO: creates empty letsencrypt.log.1 file
handler.setLevel(logging.DEBUG) handler.setLevel(logging.DEBUG)
handler_formatter = logging.Formatter(fmt=fmt) handler_formatter = logging.Formatter(fmt=fmt)
handler_formatter.converter = time.gmtime # don't use localtime
handler.setFormatter(handler_formatter) handler.setFormatter(handler_formatter)
return handler, log_file_path return handler, log_file_path
certbot/tests/log_test.py
+1 -1
View File
@@ -156,7 +156,7 @@ class SetupLogFileHandlerTest(test_util.ConfigTestCase):
handler.close() handler.close()
self.assertEqual(handler.level, logging.DEBUG) self.assertEqual(handler.level, logging.DEBUG)
self.assertEqual(handler.formatter.converter, time.gmtime) self.assertEqual(handler.formatter.converter, time.localtime)
expected_path = os.path.join(self.config.logs_dir, log_file) expected_path = os.path.join(self.config.logs_dir, log_file)
self.assertEqual(log_path, expected_path) self.assertEqual(log_path, expected_path)