starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 08:08:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Test revert setuptools pin (#9197)

Browse Source 
* Revert setuptools-rust pin

This was a temporary workaround to fix
https://github.com/certbot/certbot/issues/9111, but it looks like the
the issue resolved itself

* Make mypy happy

There was an unused ignore statement, and Validator.certificate was
unnecessarily casting strings as bytes for an X509 digest method.

* Pin setuptools-rust to prevent build-dep hiccups in the future
This commit is contained in:
Will Greenberg
2022-02-10 14:10:14 -08:00
committed by GitHub
parent 9524a9fc16
commit f14cefff18
4 changed files with 47 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/pinning/current/pyproject.toml
+6 -4
View File
@@ -63,10 +63,12 @@ mock = "*"
# here in addition to certbot/setup.py because otherwise the pre-release
# version of poetry will not be installed.
poetry = ">=1.2.0a1"
# setuptools-rust 1.0+ causes some of our tests to fail. In the long term, this
# should be fixed, but this is a quick fix to get tests passing again. See
# https://github.com/certbot/certbot/issues/9111 for more info.
setuptools-rust = "<1"
# setuptools-rust is a build dependency of cryptography, and since we don't have
# a great way of pinning build dependencies, we simply list it here to ensure a
# working version. Note: if build dependencies of setuptools-rust break at some
# point, it's probably worth enumerating and pinning them (and recursing to
# THEIR build dependencies) as well.
setuptools-rust = "*"
# Library traitlets is a transitive dependency of ipdb (traitlets -> ipython -> ipdb).
# Version 5.x is incompatible with Python 3.6 but for some reasons, poetry fails to
# add the appropriate marker and allows this version to be installed under Python 3.6.