Commit Graph
11472 Commits
Author SHA1 Message Date
Erica Portnoy f304f21712 clean up name fields for reading test results 2026-04-17 15:34:49 -07:00
Erica Portnoy f8f6a24e5e clean up name fields for reading test results 2026-04-17 15:34:35 -07:00
Erica Portnoy dbc13a844e clean up files 2026-04-17 15:27:02 -07:00
Erica Portnoy 95ac7bc382 add checker job to enable required checks; remove vestigial name field 2026-04-17 15:19:25 -07:00
Erica Portnoy 847ad37c51 add checker job to enable required checks; remove vestigial name field 2026-04-17 15:19:01 -07:00
Erica Portnoy 87492dec3d Merge branch 'convert-pr-tests' into convert-certbot-pr-test-suite-to-actions-20260323-163455 2026-04-17 14:48:05 -07:00
Erica Portnoy 3c8b6dbbcb convert .azure-pipelines/main.yml to .github/workflows/pr-test-suite.yml to run PR test suite 2026-04-17 14:41:34 -07:00
Erica Portnoy dd436786b0 add standard tests jobs; compare to .azure-pipelines/templates/jobs/standard-tests-jobs.yml which is still needed for other pipelines on azure 2026-04-17 14:40:54 -07:00
Erica Portnoy 7690b4c019 add tox steps; compare to .azure-pipelines/templates/steps/tox-steps.yml which is still needed for other pipelines on azure 2026-04-17 14:39:39 -07:00
Erica Portnoy d2c39a3980 add sphinx tests; compare to .azure-pipelines/templates/steps/sphinx-steps.yml which is still needed for other pipelines on azure 2026-04-17 14:39:01 -07:00
Erica Portnoy 9086feb49a modify .gitignore to ignore files created during the migration process 2026-04-17 14:26:26 -07:00
Erica Portnoy a81503dcf8 set permissions 2026-04-17 14:20:48 -07:00
Erica Portnoy aa0ad640b1 allow running main workflows manually 2026-04-17 13:51:28 -07:00
Erica Portnoy fbeabd4dcf switch extended tests to new format; remove setup_tox and run_tox actions 2026-04-17 13:23:02 -07:00
Erica Portnoy 0c93b29d8a refactor tox steps into workflow; export env using GITHUB_ENV 2026-04-17 13:19:36 -07:00
Erica Portnoy c18e53e6c6 cut brew prefix back down 2026-04-17 12:52:31 -07:00
Erica Portnoy 43626306a1 transfer CFLAGS from setup to run actions 2026-04-17 12:51:00 -07:00
Erica Portnoy 81d482dcac export more details cflags 2026-04-17 12:43:22 -07:00
Erica Portnoy 533525284c use SNAP_ARCH not arch-name 2026-04-17 11:59:08 -07:00
Erica Portnoy 340f43235f quote armhf 2026-04-17 11:59:08 -07:00
Erica Portnoy 7636bd5a66 get snap files with flat layout 2026-04-17 11:58:57 -07:00
Erica Portnoy bdcd06b328 rerun nightly tests on failure 2026-04-16 19:23:02 -07:00
Erica Portnoy 2320d1ea60 remove choice as it is not allowed in workflow_call; add validation job 2026-04-16 19:23:02 -07:00
Erica Portnoy 94d83feca3 change type choice ordering 2026-04-16 19:23:02 -07:00
Erica Portnoy a673937e46 export cflags to try to find augeas.h 2026-04-16 19:23:02 -07:00
Erica Portnoy 1632ff35d1 pass variables through better 2026-04-16 19:23:02 -07:00
Erica Portnoy 3c077568ff add nightly tests 2026-04-16 19:23:02 -07:00
Erica Portnoy e27756959c Build all snaps on all archs including dns; test on arm64 and amd64 2026-04-16 19:23:02 -07:00
Erica Portnoy 5abc392030 migrate advanced tests to github actions
credentials for launchpad may or may not be working.
2026-04-16 19:23:02 -07:00
Erica Portnoy 736fecc85f add slightly nicer label 2026-04-16 19:23:02 -07:00
Erica Portnoy 6b9184c1c6 user newer versions of standard actions to get rid of node deprecation warning 2026-04-16 19:23:02 -07:00
Erica Portnoy 14cd7451b4 remove combined tox steps file so we can see better names 2026-04-16 19:23:02 -07:00
Erica Portnoy e9d9f76c68 cancel runs when a new commit is pushed to a pr branch 2026-04-16 19:23:02 -07:00
Erica Portnoy 62f6736222 add nicer names 2026-04-16 19:23:02 -07:00
Erica Portnoy ea49e96532 split into setup/run/upload 2026-04-16 19:23:02 -07:00
Erica Portnoy 2f20c993a0 remove tox steps workflow, that won't work 2026-04-16 19:23:02 -07:00
Erica Portnoy a9db62ebc4 stop failing fast 2026-04-16 19:23:02 -07:00
Erica Portnoy 489cef4bab run all jobs even if one fails 2026-04-16 19:23:02 -07:00
Erica Portnoy cb27f4677e add eof newlines
pass secrets and env vars

set minimum permissions

move permissions to job level, switch to contents read

change name to AWS_TEST_FARM_PEM for consistency

move comments, remove azure pipelines on-pr file

match permissions

remove runs-on: self-hosted. why was that even there?

add shell:bash

the auto-converted decided python 3.1 == 3.10. come on.

put python version in quotes

move python version to matrix

copy from matrix into env

matrix must take a list

update matrix syntax

remove composite

put composite back
2026-04-16 19:23:02 -07:00
Erica Portnoy a7af7be2d4 update gitignore 2026-04-16 19:23:02 -07:00
ohemorangeandErica Portnoy bc6a84917a Add workflow certbot/pr-test-suite
Add composite action azure_pipelines_templates_steps_tox_steps

Add composite action azure_pipelines_templates_steps_sphinx_steps

Add reusable workflow azure_pipelines_templates_jobs_standard_tests_jobs

rename files
2026-04-16 19:23:02 -07:00
Brad WarrenandGitHub 3a5c92c6be update base docker image (#10620)
fixes https://github.com/certbot/certbot/issues/10619

you can see docker builds and tests passing on this change at
https://dev.azure.com/certbot/certbot/_build/results?buildId=10360&view=results

i'm also creating a calendar event for us so we remember to keep this
updated in the future

i don't think this PR requires two reviews
2026-04-13 12:21:34 -07:00
Brad WarrenandGitHub 0cc0844f2c Release certbot 5.5.0 (#10616) 2026-04-07 14:29:50 -07:00
Erica Portnoy fc91823888 Bump version to 5.6.0 2026-04-07 09:38:18 -07:00
Erica Portnoy 6a7443f654 Remove built packages from git 2026-04-07 09:38:18 -07:00
Erica Portnoy 82dda45352 Release 5.5.0 v5.5.0 2026-04-07 09:38:17 -07:00
Erica Portnoy 171cb29183 Update changelog for 5.5.0 release 2026-04-07 09:37:45 -07:00
0eb8af20a5 Add @ing mattermost notifications to release build successes and failures (#10604)
Fixes https://github.com/certbot/certbot/issues/10599

This approach creates a new azure stage Notify and posts to the
mattermost webhook directly from within azure.

The python script uses the azure rest api to get the status of the
Deploy stage specifically. This will be failed if it failed, or skipped
if a previous stage failed, or abandoned if it timed out.

We may want to remove the existing azure build failure notification when
this is merged. It can be deleted from
[here](https://dev.azure.com/certbot/certbot/_settings/serviceHooks)
(it's the one that says "Build release, status Failed"), although
personally I think it's fine to keep it.

History of alternate general approaches I investigated:

1. give azure a custom file to say a message that depends on the
requestedBy field. impossible. no custom messages at all, much less
dependant ones.
2. hook azure build completed webhook trigger directly to github
respository_dispatch event. impossible. azure will send data in a
[specific
format](https://learn.microsoft.com/en-us/azure/devops/service-hooks/events?view=azure-devops#build.complete),
which is not the format [github
requires](https://docs.github.com/en/rest/repos/repos?apiVersion=2026-03-10#create-a-repository-dispatch-event).
3. option 2, but put a custom server somewhere to translate them. or to
grab azure and send directly to mattermost. this is a horrible idea; no
one wants to be managing a production server with secrets on it.
4. a mattermost bot is just a special user account. the sender still has
to format the data so mm can read it.
5. block on migrating from azure to github actions. drawback: this will
likely take a while, and also we're not definitely doing it. see
https://github.com/certbot/certbot/issues/10581
6. smaller than 5; wrap release in a github action that calls azure
inside of it. and then if we end up migrating more, it should be pretty
smooth to move things inside of actions. drawback: this will probably
not integrate as smoothly, given we use the azure integration. I did not
investigate further.
7. there doesn't seem to be any sort of github actions event about
builds passing on a certain branch that we can check
8. just message mattermost directly from within the pipeline as a final
stage --> where I landed.

There's further discussion in the comments about others ways we tried to
structure the pipeline and get information from azure that's not super
necessary to read to review this PR.

Relevant links:

https://learn.microsoft.com/en-us/azure/devops/service-hooks/events?view=azure-devops#build.complete

https://learn.microsoft.com/en-us/azure/devops/service-hooks/services/webhooks?view=azure-devops#resource-details-to-send

https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#agent-variables

https://learn.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=azure-devops&tabs=yaml#job-status-functions


https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows

https://docs.github.com/en/rest/repos/repos?apiVersion=2026-03-10#create-a-repository-dispatch-event

https://docs.github.com/en/webhooks/webhook-events-and-payloads#repository_dispatch

Results of tests with the latest code are here:

https://dev.azure.com/certbot/certbot/_build/results?buildId=10309&view=results

https://dev.azure.com/certbot/certbot/_build/results?buildId=10310&view=results

https://dev.azure.com/certbot/certbot/_build/results?buildId=10311&view=results

Plus the mattermost messages did get sent.

---------

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
2026-04-02 14:14:27 -07:00
Brad WarrenandGitHub 08c2354f46 update poetry (#10615)
this is in response to
https://github.com/certbot/certbot/security/dependabot/126

as you can see by examining the github status checks on this PR, i ran
the full test suite and everything passed

i also don't think this PR requires two reviews
2026-04-02 14:11:07 -07:00
ohemorangeandGitHub 3d803821b7 Repin dependencies (#10611) 2026-03-27 09:03:31 -07:00