Roy Wellington Ⅳ
e9d981aceb
Change zope's classProvides to be a class decorator.
...
When attempting to import any module that uses
zope.interface.classProvides in Python 3, a TypeError is raised; it
reads:
TypeError: Class advice impossible in Python3. Use the @provider
class decorator instead.
Following the listed advice seems to function in Python 3.
2016-02-20 00:41:01 -08:00
Roy Wellington Ⅳ
b6142c13d6
Change zope's implements to be a class decorator.
...
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:
TypeError: Class advice impossible in Python3. Use the @implementer
class decorator instead.
Following the listed advice seems to function in Python 3.
2016-02-20 00:37:40 -08:00
Filip Ochnik
0554163ff9
Additional tests for webroot cleanup
2016-02-17 17:21:25 +08:00
Filip Ochnik
4d9f487e89
Handle rmdir failure
2016-02-17 17:04:10 +08:00
Filip Ochnik
9b5ff7bcd7
Remove acme-challenge after cleaning up all challenges
2016-02-16 20:46:42 +08:00
Filip Ochnik
780c9ce2ae
Refactor path logic in webroot plugin
2016-02-16 20:36:46 +08:00
Filip Ochnik
69e1c62859
Add test for cleaning up acme-challenge
2016-02-16 20:33:22 +08:00
Peter Eckersley
9c7e99cbf5
Merge pull request #2397 from thanatos/future-pylint-fixes
...
Fix import ordering s.t. future versions of pylint won't warn on it.
2016-02-15 11:59:08 -08:00
Peter Eckersley
64600ff61c
Place a signpost about default detection for plugin args
2016-02-09 17:52:30 -08:00
bmw
bfb5f7ee9d
Merge pull request #2352 from letsencrypt/2348
...
More helpful error messages if trying to renew with standalone and bound ports
2016-02-09 15:53:53 -08:00
Peter Eckersley
54600409f8
Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt into webroot-map-and-flags
2016-02-08 20:46:51 -08:00
Peter Eckersley
362a9a239d
Merge pull request #2404 from letsencrypt/renew-integration-v2
...
Renew integration tests v2
2016-02-08 19:45:24 -08:00
Peter Eckersley
a774922f8f
Revert "Revert "Allow webroot-map and --csr to exist together.""
...
This reverts commit d65a3c65c2
2016-02-08 18:14:55 -08:00
Brad Warren
4038be9816
Test manual prepare()
2016-02-08 18:06:56 -08:00
Brad Warren
77616a975b
Allow non-interactive with test-mode
2016-02-08 17:59:30 -08:00
Brad Warren
24a3b66b1c
Use server_close() in standalone
2016-02-08 17:52:12 -08:00
Peter Eckersley
d65a3c65c2
Revert "Allow webroot-map and --csr to exist together."
2016-02-08 17:25:47 -08:00
Roy Wellington Ⅳ
2369f1253b
Fix import ordering s.t. future versions of pylint won't warn on it.
...
pylint gets more strict about import order in the future, so adjust it
now to make upgrading smoother. pylint is following the order from
PEP-8:
> Imports should be grouped in the following order:
>
> 1. standard library imports
> 2. related third party imports
> 3. local application/library specific imports
>
> You should put a blank line between each group of imports.
2016-02-07 12:58:35 -08:00
Peter Eckersley
6df94bf68d
Better webroot configuration error
...
Fixes : #2377
2016-02-06 13:48:09 -08:00
Peter Eckersley
7bfe246c63
Merge remote-tracking branch 'origin/renew_verb' into 2348
2016-02-05 09:57:28 -08:00
Peter Eckersley
4d8dbc9d81
Lint this entire monstrosity
...
- Doing some of @schoen's refactoring homework for him :)
2016-02-03 18:55:06 -08:00
Noah Swartz
3697ca7e3e
throw an error if manual is run non-interactively
2016-02-02 17:56:12 -08:00
Peter Eckersley
c2fa9b95c1
Pick a display height that works pretty well
2016-02-02 17:05:54 -08:00
Peter Eckersley
c084814c6f
Attempt to display better...
2016-02-02 17:01:00 -08:00
Peter Eckersley
ccd58dea5b
More helpful error when renewing with standalone
2016-02-02 16:47:42 -08:00
Peter Eckersley
bbb25c7d1b
Merge remote-tracking branch 'origin/master' into non-interactive
...
(Merge conflict due to PEP8iness)
2016-01-15 16:04:38 -08:00
Filip Ochnik
b89d383ff4
Add tests for missing paths in webroot plugin
2016-01-15 11:38:21 +07:00
Filip Ochnik
2a6d3bedb6
Fix missing --webroot-path handling in webroot plugin
2016-01-15 11:37:20 +07:00
Brad Warren
8680a29c9d
Merge branch 'master' into pyopenssl
2016-01-02 13:11:11 -05:00
Peter Eckersley
6daaa7a763
Add defaults / cli_flags for yesno() input
2015-12-29 00:03:57 -08:00
Peter Eckersley
f5cf58f42e
with .. open .. as # definitely nicer
2015-12-22 15:42:53 -08:00
Peter Eckersley
e41339cda8
Keep lint happy
...
(But what about py3?)
2015-12-21 20:01:28 -08:00
Peter Eckersley
aa6bf73d4a
Only test permission failures if we're not root
...
or, more generally, if we're on a system where permissions are being enforced
Closes : #1979
2015-12-21 19:58:07 -08:00
Brad Warren
20b3188c65
No kwargs plz
2015-12-16 19:46:56 -08:00
Peter Eckersley
0751244597
Merge pull request #1875 from letsencrypt/webroot-permissions
...
Webroot permissions
2015-12-12 00:32:16 -08:00
Brad Warren
1a7dd76288
Added test coverage
2015-12-11 19:31:50 -08:00
Brad Warren
d45865a601
Cleanup
2015-12-11 19:14:23 -08:00
Brad Warren
2d52559466
Cleanup comment
2015-12-11 18:12:46 -08:00
Joe Ranweiler
f4d499dbad
Make help message indicate derived challenge preference
2015-12-11 18:07:25 -08:00
Joe Ranweiler
2f904a41e0
Derive preference order from supported_challenges order
2015-12-11 18:06:11 -08:00
Brad Warren
74927613e9
Fixed lint issues
2015-12-11 18:03:52 -08:00
Joe Ranweiler
c66c6bae1d
Make supported_challenges return a list, not set
2015-12-11 18:00:33 -08:00
Luca Beltrame
2b942d97b2
Address review comments
...
- move the umask call before the try/except block
- move comment in _prepare_single to the umask call
Simplify the code comments, too.
Tests still pass.
2015-12-07 11:17:29 +01:00
Luca Beltrame
edf3a4ed73
Make webroot usable also when running as non-root (GH #1795 )
...
Thanks to @aburch's suggestions, the logic has been changed:
- Set umask before creating folders and files
- Leverage os.makedirs' mode option in conjunction with umask
The program still tries to change owner / group, but in case of errors
it continues gracefully.
Tests have been updated, and they pass.
2015-12-07 10:49:24 +01:00
Joe Ranweiler
dbf181ebac
Respect config when stating challenge preferences
2015-12-03 00:28:12 -08:00
Joe Ranweiler
8cf47e3aba
Add tests to check that configuration is used
...
The existing tests use the case in which the (configured) supported
challenges are equal to the defaults, and in the same (now-fixed) order.
These additional tests check that, if we have configured a subset of the
supported challenges, then we actually _use_ that configuration.
2015-12-03 00:13:09 -08:00
Joe Ranweiler
d5511971aa
Update plugin help string
2015-12-02 22:50:32 -08:00
Joe Ranweiler
fa55871598
Remove dead import
2015-12-02 22:14:32 -08:00
Joe Ranweiler
a0142dbe44
Don't randomize challenge preference
2015-12-02 22:13:05 -08:00
Joe Ranweiler
144a678473
Encode challenge preference order in constant
2015-12-02 22:12:18 -08:00
Roy Wellington Ⅳ