488 Commits
Author SHA1 Message Date
Liam Marshall 1d2ba931b3 Improve the implementation of the suggestion
Write the code to set directives

Fix logging in _remove_existing_ssl_directives

Fix logging statement
2015-11-09 22:13:25 -06:00
Liam Marshall 18da7dfce2 Implement @pde's suggestions for Apache
From this IRC log:
2015-11-02 16:31:29	@pdeee	for >= 2.4.8:
2015-11-02 16:32:23	@pdeee	add new SSLCertificateFile pointing to fullchain.pem
2015-11-02 16:33:10	@pdeee	remove all preexisting SSLCertificateFile, SSLCertificateChainFile, SSLCACertificatePath, and possibly other fields subject to careful research :)
2015-11-02 16:33:21	@pdeee	for < 2.4.8:
2015-11-02 16:34:03	@pdeee	add SSLCertificateFile pointing to cert.pem
2015-11-02 16:34:42	@pdeee	and SSLCertificateChainFile pointing to chain.pem
2015-11-02 16:34:50	xamnesiax	gotcha
2015-11-02 16:34:55	@pdeee	remove all preexisting/conflicting entries
2015-11-02 16:35:19	xamnesiax	Am I correct to assume that this can all be done from deploy_certs in the apache configurator?
2015-11-02 16:36:32	xamnesiax	deploy_cert *
2015-11-02 16:36:48	@pdeee	I think so
2015-11-02 16:36:59	@pdeee	again, jdkasten may wish to say more

Pull strings out for find_dir

A bit of logging

Add version logging

Logging, temporarily remove one branch

of the conditional for testing

Fix bad directive stringgrabbing code

Fix directive removal logic

Grab string from tree to be removed
2015-11-09 22:12:39 -06:00
Joona Hoikkala 747b7ca507 More robust way of detecting the mod_macro vhosts 2015-11-10 05:34:15 +02:00
Peter Eckersley 6fbcebd4ab Merge pull request #1385 from joohoi/modmacro
Ignore mod_macro vhosts, and display notification
2015-11-09 19:03:11 -08:00
Brad Warren 0143d77362 Removed revert_challenge_config 2015-11-09 18:47:38 -08:00
Brad Warren 0c197c955e Revert all changes in cleanup, temporary or otherwise 2015-11-09 18:44:30 -08:00
bmw 4dc3ee7446 Merge pull request #1390 from letsencrypt/1274
Remove nonsensical Apache config directives
2015-11-09 15:41:27 -08:00
bmw af0229d38a Merge pull request #1401 from letsencrypt/ssl-options
Downgrade a very excitable security comment to an XXX
2015-11-09 15:38:04 -08:00
sagi de338c7309 Add tests for Upgrade-Insecure-Requests 2015-11-09 22:36:00 +00:00
sagi ffe32c6ca4 Add tests and comments 2015-11-08 15:21:36 +00:00
sagi 04136cfbf2 Generalized http-header enhancement 2015-11-08 04:37:57 +00:00
Jakub Warmuz d0a2b38457 pep8 for docs/conf.py 2015-11-07 19:36:08 +00:00
Jakub Warmuz 937e3edfc1 tls-sni-01 in apache and nginx plugins 2015-11-07 18:35:41 +00:00
Jakub Warmuz 5e8ed2bbd2 --dvsni-port -> --tls-sni-01-port 2015-11-07 18:24:17 +00:00
Peter Eckersley a6a00c108b Update test to reflect name change. 2015-11-07 03:02:32 -08:00
Joona Hoikkala ce501f94a3 Simplify the code 2015-11-07 08:31:46 +02:00
sagi 2988a09087 Make lint happy, delete trailing whitespaces 2015-11-07 05:24:55 +00:00
Peter Eckersley 63135be7c2 Downgrade a very excitable security comment to an XXX
Resolves: #1400

Also note that this function will need to become more sophisticated as we
support autoupdating of config options (eg those changed in #1390)
2015-11-06 19:36:22 -08:00
sagi 93e2023f87 Add HSTS enhancement basic tests 2015-11-06 22:32:02 +00:00
sagi 0473c67c48 Add HSTS header enhancement to Apache 2015-11-06 22:31:30 +00:00
Peter Eckersley 291c5c7132 Remove nonsensical Apache config directives
- AcceptPathInfo Off was breaking things (fixes: #1274)
- Enabling DEFLATE compression for HTML and XML may make the site vulnerable to BREACH!
2015-11-06 12:42:13 -08:00
Joona Hoikkala 980b4ac3fa PEP8 and sphinx documentation fixes 2015-11-06 20:14:00 +02:00
Joona Hoikkala effc1ed8e4 Fix VirtualHost magic methods to take mod_macro addition into account 2015-11-06 20:13:49 +02:00
Joona Hoikkala 8fb3956ecd Removed dead code 2015-11-06 20:13:44 +02:00
Joona Hoikkala f0c059752f Added test for mod_macro check in domain names 2015-11-06 20:13:39 +02:00
Joona Hoikkala 88b89a04b1 Fix pylint in the new test 2015-11-06 20:13:12 +02:00
Joona HoikkalaandJoona Hoikkala 93a53d5078 Added test for removing mod_macro vhosts from vhost list 2015-11-06 11:50:29 +02:00
Joona HoikkalaandJoona Hoikkala ba3db558d5 Tests taking mod_macro into account 2015-11-06 11:50:24 +02:00
Joona HoikkalaandJoona Hoikkala 4bd0330ae7 Do not suggest mod_macro vhost for the best vhost 2015-11-06 11:50:18 +02:00
Joona HoikkalaandJoona Hoikkala aa0161fbec Let's avoid breaking backwards compatibility 2015-11-06 11:49:56 +02:00
Joona HoikkalaandJoona Hoikkala 9f8ab4677e Ignoring mod_macro virtualhosts, but displaying a notification why it's done 2015-11-06 11:49:43 +02:00
Noah Swartz 5fd4ed9d9d added documentation explaining why we're loading lens 2015-11-04 19:43:11 -08:00
Noah Swartz af5ab05a58 Revert "switched the httpd.aug to the version from 1.2"
This reverts commit 60fce0b22e.
2015-11-04 19:34:24 -08:00
Jakub Warmuz f5053ba8af constants.AUGEAS_LENS_DIR 2015-11-04 20:12:39 +00:00
Jakub Warmuz ac137fc00a Merge remote-tracking branch 'github/letsencrypt/master' into test-embed-lens 2015-11-04 19:38:43 +00:00
Noah Swartz 60fce0b22e switched the httpd.aug to the version from 1.2 2015-11-03 11:08:10 -08:00
Noah Swartz c0048d7480 load augeas httpd lens from inside of lets encrypt 2015-11-02 16:22:58 -08:00
Jakub Warmuz 44adeadf1b Merge remote-tracking branch 'github/letsencrypt/master' into http-01 2015-11-01 11:09:59 +00:00
Jakub Warmuz 063544817b Kill simplehttp apache/nginx 2015-11-01 11:01:22 +00:00
Jakub Warmuz f8185c1913 Add Python 2.6 setup.py classifiers. 2015-10-31 11:47:25 +00:00
Noah Swartz fbd09ddbf6 added interesticial saves to apache changes which fixed bug when multiple vhosts were specified 2015-10-30 13:24:55 -07:00
bmw 2ed0b42d3f Merge pull request #1171 from chk1/master
Fix readthedocs Intersphinx URLs
2015-10-29 16:37:06 -07:00
Noah Swartz 05be568e9e added todo notes 2015-10-29 15:18:48 -07:00
David Kreitschmann 39c83d17d7 Add -t to apache2ctl -D DUMP_RUN_CFG
Calling apache2ctl -D DUMP_RUN_CFG on Debian Wheezy (Apache 2.2) will
open a socket which breaks standalone auth. letsencrypt still won’t
work with apache 2.2 because it only returns „Syntax OK“.
Apache 2.4 works the same with or without -t.
2015-10-29 10:06:32 +01:00
Christoph Kisfeld f8da08e6a2 Fix readthedocs Intersphinx URLs, fix #1140 2015-10-28 11:37:24 +01:00
Jakub Warmuz 5deba95423 RTD: install local deps for subpkgs (fixes #1086). 2015-10-23 19:01:13 +00:00
Jakub WarmuzandPeter Eckersley 762e9e578f Split letsencrypt-apache API docs 2015-10-21 17:06:36 -07:00
Jakub WarmuzandPeter Eckersley fe49889b16 Per subpkg requirements.txt for RTD 2015-10-21 17:06:36 -07:00
Jakub WarmuzandPeter Eckersley f922b9b694 Split docs into subpkgs (fixes #969) 2015-10-21 17:06:36 -07:00
Jakub WarmuzandPeter Eckersley 946ee63238 docs_extra for subpkgs 2015-10-21 17:06:36 -07:00