starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-04 12:21:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Updating TODO items

Browse Source
This commit is contained in:
Seth Schoen
2015-05-10 22:45:35 -07:00
parent b235dc4c80
commit 1e39b72ab7
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
letsencrypt/client/renewer.py
+2 -6
View File
@@ -14,8 +14,6 @@ configuration."""
# TODO: when renewing or deploying, update config file to # TODO: when renewing or deploying, update config file to
# memorialize the fact that it happened # memorialize the fact that it happened
import code #XXX: remove
import configobj import configobj
import copy import copy
import datetime import datetime
@@ -70,7 +68,6 @@ def renew(cert, old_version):
# TODO: Notify user? (authenticator could not be found) # TODO: Notify user? (authenticator could not be found)
return False return False
authenticator.prepare() authenticator.prepare()
account = client.determine_account(config) account = client.determine_account(config)
# TODO: are there other ways to get the right account object, e.g. # TODO: are there other ways to get the right account object, e.g.
@@ -78,7 +75,6 @@ def renew(cert, old_version):
# renewalparams? # renewalparams?
our_client = client.Client(config, account, authenticator, None) our_client = client.Client(config, account, authenticator, None)
# XXX: find the domains
with open(cert.version("cert", old_version)) as f: with open(cert.version("cert", old_version)) as f:
sans = crypto_util.get_sans_from_cert(f.read()) sans = crypto_util.get_sans_from_cert(f.read())
new_cert, new_key, new_chain = our_client.obtain_certificate(sans) new_cert, new_key, new_chain = our_client.obtain_certificate(sans)
@@ -89,9 +85,9 @@ def renew(cert, old_version):
# new_key if the old key is to be used (since save_successor # new_key if the old key is to be used (since save_successor
# already understands this distinction!) # already understands this distinction!)
cert.save_successor(old_version, new_cert, new_key, new_chain) cert.save_successor(old_version, new_cert, new_key, new_chain)
# Notify results # TODO: Notify results
else: else:
# Notify negative results # TODO: Notify negative results
pass pass
# TODO: Consider the case where the renewal was partially successful # TODO: Consider the case where the renewal was partially successful