starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-02 19:31:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use a set for pre_hook.already

Browse Source
This commit is contained in:
Brad Warren
2017-01-04 12:57:54 -08:00
parent b748f1afe4
commit 458c7c8131
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
certbot/hooks.py
+2 -2
View File
@@ -54,11 +54,11 @@ def pre_hook(config):
if cmd and cmd not in pre_hook.already: if cmd and cmd not in pre_hook.already:
logger.info("Running pre-hook command: %s", cmd) logger.info("Running pre-hook command: %s", cmd)
_run_hook(cmd) _run_hook(cmd)
pre_hook.already[cmd] = True pre_hook.already.add(cmd)
elif cmd: elif cmd:
logger.info("Pre-hook command already run, skipping: %s", cmd) logger.info("Pre-hook command already run, skipping: %s", cmd)
pre_hook.already = {} pre_hook.already = set()
def post_hook(config): def post_hook(config):
certbot/tests/hook_test.py
+1 -1
View File
@@ -47,7 +47,7 @@ class HookTest(unittest.TestCase):
return mock_logger.warning return mock_logger.warning
def test_pre_hook(self): def test_pre_hook(self):
hooks.pre_hook.already = {} hooks.pre_hook.already = set()
config = mock.MagicMock(pre_hook="true") config = mock.MagicMock(pre_hook="true")
self._test_a_hook(config, hooks.pre_hook, 1) self._test_a_hook(config, hooks.pre_hook, 1)
self._test_a_hook(config, hooks.pre_hook, 0) self._test_a_hook(config, hooks.pre_hook, 0)