From 470cad14ad9e5a8aab9dbd56efa8b0e3d7fdad09 Mon Sep 17 00:00:00 2001 From: Seth Schoen Date: Mon, 9 Feb 2015 09:54:33 -0800 Subject: [PATCH] Add missing return statements in start_listener() --- letsencrypt/client/standalone_authenticator.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/letsencrypt/client/standalone_authenticator.py b/letsencrypt/client/standalone_authenticator.py index 5043ccd26..afffa7cb3 100644 --- a/letsencrypt/client/standalone_authenticator.py +++ b/letsencrypt/client/standalone_authenticator.py @@ -197,11 +197,15 @@ class StandaloneAuthenticator(object): if fork_result: # PARENT process (still the Let's Encrypt client process) self.child_pid = fork_result - self.do_parent_process(port) + # do_parent_process() can return True or False to indicate + # reported success or failure creating the listener. + return self.do_parent_process(port) else: # CHILD process (the TCP listener subprocess) self.child_pid = os.getpid() - self.do_child_process(port, key) + # do_child_process() is normally not expected to return but + # should terminate via sys.exit(). + return self.do_child_process(port, key) # IAuthenticator method implementations follow