mirror of
https://github.com/certbot/certbot.git
synced 2026-08-01 02:44:21 +02:00
Fix Pylint upgrade issues
* Remove unsupported pylint disable options
* star-args removed in Pylint 1.4.3
* abstract-class-little-used removed in Pylint 1.4.3
* Fixes new lint errors
* Copy dummy-variable-rgx expression to new ignored-argument-names expression to ignore unused funtion arguments
* Notable changes
* Refactor to satisfy Pylint no-else-return warning
* Fix Pylint inconsistent-return-statements warning
* Refactor to satisfy consider-iterating-dictionary
* Remove methods with only super call to satisfy useless-super-delegation
* Refactor too-many-nested-statements where possible
* Suppress type checked errors where member is dynamically added (notably derived from josepy.JSONObjectWithFields)
* Remove None default of func parameter for ExitHandler and ErrorHandler
Resolves #5973
This commit is contained in:
@@ -44,7 +44,7 @@ class Authenticator(dns_common.DNSAuthenticator):
|
||||
def _setup_credentials(self):
|
||||
pass
|
||||
|
||||
def _perform(self, domain, validation_domain_name, validation): # pylint: disable=missing-docstring
|
||||
def _perform(self, domain, validation_name, validation): # pylint: disable=missing-docstring
|
||||
pass
|
||||
|
||||
def perform(self, achalls):
|
||||
@@ -65,9 +65,9 @@ class Authenticator(dns_common.DNSAuthenticator):
|
||||
raise errors.PluginError("\n".join([str(e), INSTRUCTIONS]))
|
||||
return [achall.response(achall.account_key) for achall in achalls]
|
||||
|
||||
def _cleanup(self, domain, validation_domain_name, validation):
|
||||
def _cleanup(self, domain, validation_name, validation):
|
||||
try:
|
||||
self._change_txt_record("DELETE", validation_domain_name, validation)
|
||||
self._change_txt_record("DELETE", validation_name, validation)
|
||||
except (NoCredentialsError, ClientError) as e:
|
||||
logger.debug('Encountered error during cleanup: %s', e, exc_info=True)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user