diff --git a/CHANGELOG.md b/CHANGELOG.md index 2f7582a14..34838bdc3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,7 +43,7 @@ More details about these changes can be found on our GitHub repo. * Fedora 29+ is now supported by certbot-auto. Since Python 2.x is on a deprecation path in Fedora, certbot-auto will install and use Python 3.x on Fedora 29+. -* CLI flag `--http-port` has been added for Nginx plugin exclusively, and replaces +* CLI flag `--https-port` has been added for Nginx plugin exclusively, and replaces `--tls-sni-01-port`. It defines the HTTPS port the Nginx plugin will use while setting up a new SSL vhost. By default the HTTPS port is 443. @@ -71,6 +71,7 @@ Despite us having broken lockstep, we are continuing to release new versions of all Certbot components during releases for the time being, however, the only package with changes other than its version number was: +* acme * certbot * certbot-apache * certbot-nginx diff --git a/certbot-nginx/local-oldest-requirements.txt b/certbot-nginx/local-oldest-requirements.txt index b0b1ca6f5..7ee0d9e09 100644 --- a/certbot-nginx/local-oldest-requirements.txt +++ b/certbot-nginx/local-oldest-requirements.txt @@ -1,2 +1,2 @@ acme[dev]==0.29.0 -certbot[dev]==0.33.1 +certbot[dev]==0.33.0 diff --git a/certbot/storage.py b/certbot/storage.py index d0bc36c08..48587ba40 100644 --- a/certbot/storage.py +++ b/certbot/storage.py @@ -238,16 +238,17 @@ def _write_live_readme_to(readme_path, is_base_dir=False): "certificates.\n".format(prefix=prefix)) -def _relevant(option): +def _relevant(namespaces, option): """ Is this option one that could be restored for future renewal purposes? + + :param namespaces: plugin namespaces for configuration options + :type namespaces: `list` of `str` :param str option: the name of the option :rtype: bool """ from certbot import renewal - plugins = plugins_disco.PluginsRegistry.find_all() - namespaces = [plugins_common.dest_namespace(plugin) for plugin in plugins] return (option in renewal.CONFIG_ITEMS or any(option.startswith(namespace) for namespace in namespaces)) @@ -262,10 +263,13 @@ def relevant_values(all_values): :rtype dict: """ + plugins = plugins_disco.PluginsRegistry.find_all() + namespaces = [plugins_common.dest_namespace(plugin) for plugin in plugins] + rv = dict( (option, value) for option, value in six.iteritems(all_values) - if _relevant(option) and cli.option_was_set(option, value)) + if _relevant(namespaces, option) and cli.option_was_set(option, value)) # We always save the server value to help with forward compatibility # and behavioral consistency when versions of Certbot with different # server defaults are used. diff --git a/docs/contributing.rst b/docs/contributing.rst index 264db630f..b69b5c43f 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -369,9 +369,11 @@ Asking for help =============== If you have any questions while working on a Certbot issue, don't hesitate to -ask for help! You can do this in the #letsencrypt-dev IRC channel on Freenode. -If you don't already have an IRC client set up, we recommend you join using -`Riot `_. +ask for help! You can do this in the Certbot channel in EFF's Mattermost +instance for its open source projects. To join, `create an account +`_ +and then visit the `Certbot channel +`_. Updating certbot-auto and letsencrypt-auto ==========================================