From 7ee2b9ef21a0318cb7cc7849e2a98b222cef86e1 Mon Sep 17 00:00:00 2001 From: Seth Schoen Date: Fri, 20 Jul 2012 18:47:29 -0700 Subject: [PATCH] note priority inversion bug is now somewhat less severe --- server-ca/daemon.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server-ca/daemon.py b/server-ca/daemon.py index 5cf83dd21..3f2ee1bfc 100644 --- a/server-ca/daemon.py +++ b/server-ca/daemon.py @@ -242,11 +242,11 @@ def issue(session): # challenges before the cert could be issued. Normally, this # should never happen. # - # TODO: This can definitely happen when there are at least as many - # sessions stuck in testchallenge state as there are daemon processes - # to handle them, because all sessions in testchallenge have absolute - # priority over all sessions in issue, from each individual daemon's - # point of view! This is a bug. + # TODO: This can definitely happen when there are extremely many + # sessions stuck in testchallenge state compared to the number of + # daemon processes to handle them, because each session in + # testchallenge gets tested once before any daemon gets around to + # issuing the cert. This is a bug. if debug: print "removing expired (issue-state!?) session", session r.lrem("pending-requests", session) return