starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-02 19:31:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

ACME: omitempty Error.detail, Error.type (fixes #2289)

Browse Source
This commit is contained in:
Jakub Warmuz
2016-04-09 08:17:26 +00:00
parent b347e9fba1
commit 8145b7c11b
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
acme/acme/messages.py
+2 -2
View File
@@ -37,9 +37,9 @@ class Error(jose.JSONObjectWithFields, errors.Error):
) )
) )
typ = jose.Field('type') typ = jose.Field('type', omitempty=True, default='about:blank')
title = jose.Field('title', omitempty=True) title = jose.Field('title', omitempty=True)
detail = jose.Field('detail') detail = jose.Field('detail', omitempty=True)
@property @property
def description(self): def description(self):
acme/acme/messages_test.py
+8
View File
@@ -28,6 +28,14 @@ class ErrorTest(unittest.TestCase):
self.error_custom = Error(typ='custom', detail='bar') self.error_custom = Error(typ='custom', detail='bar')
self.jobj_cusom = {'type': 'custom', 'detail': 'bar'} self.jobj_cusom = {'type': 'custom', 'detail': 'bar'}
def test_default_typ(self):
from acme.messages import Error
self.assertEqual(Error().typ, 'about:blank')
def test_from_json_empty(self):
from acme.messages import Error
self.assertEqual(Error(), Error.from_json('{}'))
def test_from_json_hashable(self): def test_from_json_hashable(self):
from acme.messages import Error from acme.messages import Error
hash(Error.from_json(self.error.to_json())) hash(Error.from_json(self.error.to_json()))