starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-31 18:34:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ask people not to rewrite commits. (#6538)

Browse Source
This commit is contained in:
Brad Warren
2018-11-29 18:42:08 -05:00
committed by ohemorange
parent 7d0ac47139
commit 8b5ac9e257
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/contributing.rst
+4 -1
View File
@@ -359,7 +359,10 @@ Steps:
4. Run ``tox --skip-missing-interpreters`` to run the entire test suite 4. Run ``tox --skip-missing-interpreters`` to run the entire test suite
including coverage. The ``--skip-missing-interpreters`` argument ignores including coverage. The ``--skip-missing-interpreters`` argument ignores
missing versions of Python needed for running the tests. Fix any errors. missing versions of Python needed for running the tests. Fix any errors.
5. Submit the PR. 5. Submit the PR. Once your PR is open, please do not force push to the branch
containing your pull request to squash or amend commits. We use `squash
merges <https://github.com/blog/2141-squash-your-commits>`_ on PRs and
rewriting commits makes changes harder to track between reviews.
6. Did your tests pass on Travis? If they didn't, fix any errors. 6. Did your tests pass on Travis? If they didn't, fix any errors.
Asking for help Asking for help