starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-02 19:31:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Always download the pinned version of pip in pipstrap (#6691)

Browse Source 
This will immediately address the breakage reported in #6682 and tracked at #6685. Virtualenv downloads the latest pip, which causes issues, so after virtualenv upgrades pip, downgrade to the pinned version.

I've confirmed that this fixes the issue on a machine that fails with the version of certbot-auto currently in master: recent version of virtualenv, python 2.7.

* Always download the pinned version of pip in pipstrap

* Run build.py

* Update changelog

* Remove unused variable

* Run build.py
This commit is contained in:
ohemorange
2019-01-24 12:03:21 -08:00
committed by Brad Warren
parent 34d655151d
commit 9746c310d8
3 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1
View File
@@ -19,6 +19,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
* Fixed accessing josepy contents through acme.jose when the full acme.jose * Fixed accessing josepy contents through acme.jose when the full acme.jose
path is used. path is used.
* Clarify behavior for deleting certs as part of revocation. * Clarify behavior for deleting certs as part of revocation.
* Always download the pinned version of pip in pipstrap to address breakages
* Rename old,default.conf to old-and-default.conf to address commas in filenames * Rename old,default.conf to old-and-default.conf to address commas in filenames
breaking recent versions of pip. breaking recent versions of pip.
* Add VIRTUALENV_NO_DOWNLOAD=1 to all calls to virtualenv to address breakages * Add VIRTUALENV_NO_DOWNLOAD=1 to all calls to virtualenv to address breakages
letsencrypt-auto-source/letsencrypt-auto
-3
View File
@@ -1346,9 +1346,6 @@ def get_index_base():
def main(): def main():
pip_version = StrictVersion(check_output(['pip', '--version']) pip_version = StrictVersion(check_output(['pip', '--version'])
.decode('utf-8').split()[1]) .decode('utf-8').split()[1])
min_pip_version = StrictVersion(PIP_VERSION)
if pip_version >= min_pip_version:
return 0
has_pip_cache = pip_version >= StrictVersion('6.0') has_pip_cache = pip_version >= StrictVersion('6.0')
index_base = get_index_base() index_base = get_index_base()
temp = mkdtemp(prefix='pipstrap-') temp = mkdtemp(prefix='pipstrap-')
letsencrypt-auto-source/pieces/pipstrap.py
-3
View File
@@ -148,9 +148,6 @@ def get_index_base():
def main(): def main():
pip_version = StrictVersion(check_output(['pip', '--version']) pip_version = StrictVersion(check_output(['pip', '--version'])
.decode('utf-8').split()[1]) .decode('utf-8').split()[1])
min_pip_version = StrictVersion(PIP_VERSION)
if pip_version >= min_pip_version:
return 0
has_pip_cache = pip_version >= StrictVersion('6.0') has_pip_cache = pip_version >= StrictVersion('6.0')
index_base = get_index_base() index_base = get_index_base()
temp = mkdtemp(prefix='pipstrap-') temp = mkdtemp(prefix='pipstrap-')