starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 02:44:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

build_remote.py: better detection of invalid snaps

Browse Source
This commit is contained in:
Will Greenberg
2026-07-21 17:02:15 -07:00
parent c777edbf77
commit 9dd1f5eb4c
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/snap/build_remote.py
+9 -6
View File
@@ -144,14 +144,17 @@ def _build_snap(
for arch in archs: for arch in archs:
snap_path_list = glob.glob(join(workspace, f'{target}_*_{arch}.snap')) snap_path_list = glob.glob(join(workspace, f'{target}_*_{arch}.snap'))
assert len(snap_path_list) == 1 assert len(snap_path_list) == 1
with open(snap_path_list[0], 'r') as f: with open(snap_path_list[0], 'rb') as f:
first_block = f.read(10)
# 'hsqs' is the magic number that SquashFS files start with
if first_block.startswith(b'hsqs'):
continue
failed_archs.add(arch)
try: try:
first_line = f.readline().rstrip() first_block_str = first_block.decode()
except UnicodeDecodeError: except UnicodeDecodeError:
first_line = '' first_block_str = first_block.hex()
if first_line == "<!DOCTYPE html>": print(f'The {target} {arch} snap file began with invalid data: {first_block_str}')
failed_archs.add(arch)
print(f'The {target} {arch} snap file contains html instead of a snap')
dump_output = bool(failed_archs) dump_output = bool(failed_archs)
if not dump_output: if not dump_output: