From c594a258feb1333300607308bc898019d4950608 Mon Sep 17 00:00:00 2001 From: sagi Date: Fri, 11 Dec 2015 09:26:55 +0000 Subject: [PATCH] Change comment on possibility of redirection loops --- letsencrypt-apache/letsencrypt_apache/configurator.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/letsencrypt-apache/letsencrypt_apache/configurator.py b/letsencrypt-apache/letsencrypt_apache/configurator.py index 67b089909..bc12a75fe 100644 --- a/letsencrypt-apache/letsencrypt_apache/configurator.py +++ b/letsencrypt-apache/letsencrypt_apache/configurator.py @@ -886,8 +886,10 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator): # Note: if code flow gets here it means we didn't find the exact - # letsencrypt RewriteRule config for redirection. So if we find - # another RewriteRule it may induce a loop / config mismatch. + # letsencrypt RewriteRule config for redirection. Finding + # another RewriteRule is likely to be fine in most or all cases, + # but redirect loops are possible in very obscure cases; see #1620 + # for reasoning. if self._is_rewrite_exists(general_vh): logger.warn("Added an HTTP->HTTPS rewrite in addition to " "other RewriteRules; you may wish to check for "