starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 02:44:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(acme): client._revoke sends default content_type (#5687) (#5726)

Browse Source 
(cherry picked from commit f4bac423fb)
This commit is contained in:
Brad Warren
2018-03-14 18:34:59 -07:00
committed by GitHub
parent c9f278e6c8
commit d0b336085c
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
acme/acme/client.py
+1 -2
View File
@@ -227,8 +227,7 @@ class ClientBase(object): # pylint: disable=too-many-instance-attributes
response = self._post(url, response = self._post(url,
messages.Revocation( messages.Revocation(
certificate=cert, certificate=cert,
reason=rsn), reason=rsn))
content_type=None)
if response.status_code != http_client.OK: if response.status_code != http_client.OK:
raise errors.ClientError( raise errors.ClientError(
'Successful revocation must return HTTP OK status') 'Successful revocation must return HTTP OK status')
acme/acme/client_test.py
+2 -4
View File
@@ -635,8 +635,7 @@ class ClientTest(ClientTestBase):
def test_revoke(self): def test_revoke(self):
self.client.revoke(self.certr.body, self.rsn) self.client.revoke(self.certr.body, self.rsn)
self.net.post.assert_called_once_with( self.net.post.assert_called_once_with(
self.directory[messages.Revocation], mock.ANY, content_type=None, self.directory[messages.Revocation], mock.ANY, acme_version=1)
acme_version=1)
def test_revocation_payload(self): def test_revocation_payload(self):
obj = messages.Revocation(certificate=self.certr.body, reason=self.rsn) obj = messages.Revocation(certificate=self.certr.body, reason=self.rsn)
@@ -776,8 +775,7 @@ class ClientV2Test(ClientTestBase):
def test_revoke(self): def test_revoke(self):
self.client.revoke(messages_test.CERT, self.rsn) self.client.revoke(messages_test.CERT, self.rsn)
self.net.post.assert_called_once_with( self.net.post.assert_called_once_with(
self.directory["revokeCert"], mock.ANY, content_type=None, self.directory["revokeCert"], mock.ANY, acme_version=2)
acme_version=2)
class MockJSONDeSerializable(jose.JSONDeSerializable): class MockJSONDeSerializable(jose.JSONDeSerializable):