[Windows] Security model for files permissions - STEP 3b (#6965)

* Modifications for misc

* Add some types

* Use os_rename

* Move rename into filesystem

* Use our os package

* Rename filesystem.rename to filesystem.replace

* Disable globally function redefined lint in os module
This commit is contained in:
Adrien Ferrand
2019-06-11 17:08:48 -07:00
committed by Brad Warren
parent 72e5d89e95
commit d75908c645
9 changed files with 82 additions and 77 deletions
+2 -1
View File
@@ -16,6 +16,7 @@ from certbot import interfaces
from certbot import util
from certbot.compat import misc
from certbot.compat import os
from certbot.compat import filesystem
logger = logging.getLogger(__name__)
@@ -583,7 +584,7 @@ class Reverter(object):
timestamp = self._checkpoint_timestamp()
final_dir = os.path.join(self.config.backup_dir, timestamp)
try:
misc.os_rename(self.config.in_progress_dir, final_dir)
filesystem.replace(self.config.in_progress_dir, final_dir)
return
except OSError:
logger.warning("Extreme, unexpected race condition, retrying (%s)", timestamp)