starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-30 18:04:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

route53: re-use boto3 client in wait (#4724)

Browse Source 
This change re-uses the boto3 client in the wait method of the route53
authenticator in order to make it more mockable for testing purposes.
This commit is contained in:
Zach Shepherd
2017-05-24 10:37:08 -07:00
committed by GitHub
parent 033c995bd2
commit ddd10548c8
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
certbot-route53/certbot_route53/authenticator.py
+1 -2
View File
@@ -137,9 +137,8 @@ class Authenticator(common.Plugin):
"""Wait for a change to be propagated to all Route53 DNS servers. """Wait for a change to be propagated to all Route53 DNS servers.
https://docs.aws.amazon.com/Route53/latest/APIReference/API_GetChange.html https://docs.aws.amazon.com/Route53/latest/APIReference/API_GetChange.html
""" """
client = boto3.client("route53")
for n in range(0, 120): for n in range(0, 120):
response = client.get_change(Id=change_id) response = self.r53.get_change(Id=change_id)
if response["ChangeInfo"]["Status"] == "INSYNC": if response["ChangeInfo"]["Status"] == "INSYNC":
return return
time.sleep(5) time.sleep(5)