starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-31 18:34:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update generated CSRs to create V1 CSRs (#9334)

Browse Source 
* Update generated CSRs to create V1 CSRs

Per the RFC: https://datatracker.ietf.org/doc/html/rfc2986#section-4

Version 3 CSRs, as far as I can tell, are not a thing (yet).

Relevant code in Go, for example: https://cs.opensource.google/go/go/+/refs/tags/go1.18.3:src/crypto/x509/x509.go;l=1979

* Update AUTHORS.md

* Unit test for PR #9334

* Add a small comment explaining this line for future readers.

* Add info to changelog

Co-authored-by: Paul Buonopane <paul@namepros.com>
This commit is contained in:
Amir Omidi
2022-06-29 14:24:24 +10:00
committed by GitHub
co-authored by Paul Buonopane
parent b9f9952660
commit dedbdea1d9
4 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
certbot/CHANGELOG.md
+2
View File
@@ -18,6 +18,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
data, so it doesn't rely on the locally stored account URL. This fixes situations where Certbot
would use old ACMEv1 registration info with non-functional account URLs.
* The generated Certificate Signing Requests are now generated as version 1 instead of version 3. This resolves situations in where strict enforcement of PKCS#10 meant that CSRs that were generated as version 3 were rejected.
More details about these changes can be found on our GitHub repo.
## 1.28.0 - 2022-06-07