Actually all of this logic was fine, and we do need to bring in the staging server value

This commit is contained in:
Peter Eckersley
2016-02-09 12:50:49 -08:00
parent 04926a4662
commit ed348f5528
+7 -8
View File
@@ -1194,14 +1194,13 @@ class HelpfulArgumentParser(object):
if domain not in parsed_args.domains: if domain not in parsed_args.domains:
parsed_args.domains.append(domain) parsed_args.domains.append(domain)
if not self.detect_defaults: if parsed_args.staging or parsed_args.dry_run:
if parsed_args.staging or parsed_args.dry_run: if parsed_args.server not in (flag_default("server"), constants.STAGING_URI):
if parsed_args.server not in (flag_default("server"), constants.STAGING_URI): conflicts = ["--staging"] if parsed_args.staging else []
conflicts = ["--staging"] if parsed_args.staging else [] conflicts += ["--dry-run"] if parsed_args.dry_run else []
conflicts += ["--dry-run"] if parsed_args.dry_run else [] if not self.detect_defaults:
if not self.detect_defaults: raise errors.Error("--server value conflicts with {0}".format(
raise errors.Error("--server value conflicts with {0}".format( " and ".join(conflicts)))
" and ".join(conflicts)))
parsed_args.server = constants.STAGING_URI parsed_args.server = constants.STAGING_URI