Merge branch 'main' into split-launchpad

.github/pull_request_template.md

@@ -1,8 +1,8 @@
 ## Pull Request Checklist
 
 - [ ] The Certbot team has recently expressed interest in reviewing a PR for this. If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
-- [ ] If you used AI to create this PR, you have done a self-review of all AI-generated code and disclosed that your contribution was AI-generated per [EFF's AI-generated contribution policy](https://www.eff.org/about/opportunities/volunteer/coding-with-eff). You assert you have thoroughly understood, reviewed, and tested your entire submission.
+- [ ] If you used AI to create this PR, you have done a self-review of all AI-generated code and disclosed that your contribution was AI-generated per [EFF's AI-generated contribution policy](https://www.eff.org/about/opportunities/volunteer/coding-with-eff#ai-policy). You assert you have thoroughly understood, reviewed, and tested your entire submission.
 - [ ] If the change being made is to a [distributed component](https://certbot.eff.org/docs/contributing.html#code-components-and-layout), add a description of your change to the `newsfragments` directory. This should be a file called `<title>.<type>`, where `<title>` is either a GitHub issue number or some other unique name starting with `+`, and `<type>` is either `changed`, `fixed`, or `added`.
   * For example, if you fixed a bug for issue number 42, create a file called `42.fixed` and put a description of your change in that file.
 - [ ] Add or update any documentation as needed to support the changes in this PR.
-- [ ] Include your name in `AUTHORS.md` if you like.
+- [ ] Include your name in `AUTHORS.md` if you like.

.github/workflows/notify_weekly.yaml

@@ -1,29 +0,0 @@
-name: Weekly Github Update
-
-on:
-  schedule:
-    # Every week on Thursday @ 10:00
-    - cron: "0 10 * * 4"
-  workflow_dispatch:
-permissions: {}  # let's not use any permissions we don't need here
-jobs:
-  send-mattermost-message:
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Create Mattermost Message
-      run: |
-        DATE=$(date --date="7 days ago" +"%Y-%m-%d")
-        echo "ASSIGNED_PRS=https://github.com/pulls?q=is%3Apr+is%3Aopen+updated%3A%3E%3D${DATE}+assignee%3A*+user%3Acertbot" >> $GITHUB_ENV
-        echo "UPDATED_URL=https://github.com/issues?q=is%3Aissue+is%3Aopen+sort%3Acomments-desc+updated%3A%3E%3D${DATE}+user%3Acertbot" >> $GITHUB_ENV
-    # we pin this action to a version tested and audited by certbot's
-    # maintainers for extra security. the full hash is used as doing so is
-    # recommended by zizmor
-    - uses: mattermost/action-mattermost-notify@ae31bb6f9e26a54336e79696f108a2c91cf55b4e
-      with:
-        MATTERMOST_WEBHOOK_URL: ${{ secrets.MATTERMOST_WEBHOOK_URL }}
-        MATTERMOST_CHANNEL: private-certbot
-        TEXT: |
-          ## Updates In the Past Week
-          - Most commented in the last week: [link](${{ env.UPDATED_URL }})
-          - Updated (assigned) PRs in the last week: [link](${{ env.ASSIGNED_PRS }})

.github/workflows/snap_packaging_jobs.yml

@@ -46,7 +46,7 @@ jobs:
         persist-credentials: false
     - id: set-dns-dirs
       run: |
-        DNS_NAMES="$(echo certbot-dns-* | jq -R -s -c 'split(" ")[:-1]')"
+        DNS_NAMES="$(echo certbot-dns-* | jq -R -s -c 'gsub("\n"; "") | split(" ")')"
         echo "dns-dirs=$DNS_NAMES" >> "$GITHUB_OUTPUT"
   gha_build_dns_snaps:
     name: Build ${{ matrix.dns-dir }} ${{ matrix.build-for }}