Commit Graph
6941 Commits
Author SHA1 Message Date
Brad WarrenandGitHub e2a2b9914a Merge pull request #3249 from certbot/apache-uinstalled-clarity
Explain why Apache [appears] not to be installed
2016-07-06 15:16:58 -07:00
Brad WarrenandGitHub 41563aa71d Merge pull request #2767 from certbot/dialog-escape
NcursesDisplay.menu: treat ESC as cancel
2016-07-06 15:12:37 -07:00
Blake Griffith e28560514a Test that ErrorHandler resets default signals. 2016-07-06 16:56:11 -05:00
Blake Griffith 2e7f02805c Call _call_signals after _reset_signals. 2016-07-06 15:59:51 -05:00
Peter Eckersley 4b84538c8c Address review comments 2016-07-06 12:57:16 -07:00
Peter Eckersley fd35a1c724 Explain why Apache [appears] not to be installed
Would help debug #3244
2016-07-06 12:43:48 -07:00
Blake Griffith 40983d67d7 Alphabetize imports in error_handler_test.py 2016-07-06 13:19:58 -05:00
Blake Griffith 3d3908c8b3 Update _call_signals docstring. 2016-07-06 13:19:03 -05:00
Blake Griffith ece1f6a24d Don't use _private functions in tests. 2016-07-05 23:32:22 -05:00
Blake Griffith e9f879a443 Use assertTrue and index in _SIGNALS 2016-07-05 23:32:22 -05:00
Blake Griffith 7ade835476 import module instead of function 2016-07-05 23:32:22 -05:00
Blake Griffith 8333829bbe Check that ErrorHandler raises exception. 2016-07-05 23:32:22 -05:00
Blake Griffith 5e4f250110 Stylize _signal_handler docstring. 2016-07-05 23:32:22 -05:00
Blake Griffith 815887d4e4 Refactor ErrorHandler.__exit__
also call_signal -> call_signals
2016-07-05 23:32:22 -05:00
Blake Griffith 277b7a89f1 Update ErrorHandler docstring. 2016-07-05 23:32:22 -05:00
Blake Griffith 79c602ffc8 Make non-public methods as private. 2016-07-05 23:14:53 -05:00
Blake Griffith 15336d45bd Reset self.body_executed in __enter__ 2016-07-05 23:14:53 -05:00
Blake Griffith 777a654d90 Move SignalExit to errors.py 2016-07-05 23:14:53 -05:00
Brad Warren 2cd4f6f008 update FreeBSD package name 2016-07-05 14:14:31 -07:00
sagi 0e9622322a typo 2016-07-01 22:17:41 +00:00
sagi 7459360780 Add more test cases 2016-07-01 22:08:37 +00:00
sagi 15ba12ed46 Parsing State Machine + some tests 2016-07-01 21:06:16 +00:00
sagi a9abc7b39e typo 2016-07-01 15:17:37 +00:00
Peter Eckersley be8f0bc53b Do a better job of parsing map patterns 2016-06-30 15:29:38 -07:00
Peter Eckersley db8ddac4e2 lint & tweak 2016-06-30 15:13:35 -07:00
Peter Eckersley 8c3e443de9 First attempt at mitigating #3206 2016-06-30 15:07:28 -07:00
Blake Griffith 92870f0bbb Better docstring for _signal_handler 2016-06-30 10:22:12 -05:00
Peter EckersleyandGitHub 4fa182ab71 Merge pull request #3226 from certbot/freebsdbot
FreeBSD port is now py-certbot
2016-06-29 15:52:39 -07:00
Peter EckersleyandGitHub 932c9b5d07 Merge pull request #3213 from certbot/log-apache-optimism
Log / explain when Apache is optimistically falling back to *:443 vhosts
2016-06-29 15:49:14 -07:00
Brad Warren a70cf6fcf8 Use correct port name 2016-06-29 15:22:19 -07:00
Peter Eckersley 7b50960ac0 Address review comments 2016-06-29 13:57:58 -07:00
Noah Swartz b64da855a2 lint 2016-06-29 11:55:22 -07:00
Noah Swartz 395843f3f4 fix coverage 2016-06-29 11:06:18 -07:00
Noah Swartz a9679e2c25 create regression test 2016-06-28 18:08:38 -07:00
Noah Swartz 2884a7fcb7 Merge branch 'master' into issue_2983 2016-06-28 17:57:10 -07:00
Noah Swartz 78b30539fa augeas tests 2016-06-28 17:56:31 -07:00
Blake Griffith e652141449 Use lambda instead of closure. 2016-06-28 16:55:46 -05:00
Blake Griffith 1356941f97 Test signal handling in error handler. 2016-06-28 16:31:21 -05:00
Blake Griffith bbd5ce45e9 Defer signals in ErrorHandler. 2016-06-28 16:31:21 -05:00
schoenandGitHub adeb39a7f2 Merge pull request #3218 from certbot/nginx-dirty-write-only
Only write nginx config files if they've been modified
2016-06-27 14:07:51 -07:00
schoenandGitHub eaf339632a Merge pull request #3184 from certbot/nginx-space-preservation
Nginx space preservation
2016-06-27 12:50:34 -07:00
Peter Eckersley bdbdd826de Extra comment & concision 2016-06-27 12:50:06 -07:00
Peter Eckersley 3e9bf2f35f Tests for UnspacedList.is_dirty() 2016-06-27 12:50:06 -07:00
Peter Eckersley 6017a6cb6d Only write nginx config files if we've modified them 2016-06-27 12:44:36 -07:00
Peter Eckersley 184f54cbc7 cosmetic improvements 2016-06-27 12:36:28 -07:00
Peter Eckersley fdbb69930b Tweak the NotImplementedError cases 2016-06-27 12:00:41 -07:00
Amjad Mashaal 6f7ed85844 -v implies --text 2016-06-27 10:34:40 +02:00
Peter Eckersley 23f0ccbc8e Address review issues 2016-06-25 12:28:47 -07:00
Peter Eckersley e93ace79cc Test coverage & fix 2016-06-25 12:06:43 -07:00
Peter Eckersley e0691ede2c Provide clear log messages when Apache tries a default vhost 2016-06-25 10:59:41 -07:00