Commit Graph
8732 Commits
Author SHA1 Message Date
Brad WarrenandGitHub 1a79f82082 Also check new path when determining cli_command (#5082) 2017-09-06 20:22:27 -07:00
yomnaandGitHub 9fb132ba69 Merge pull request #5075 from certbot/specify-min-six-version
Specify the minimum six version in ACME
2017-09-05 17:49:42 -07:00
Brad Warren a7267b0fcd Bump version to 0.19.0 2017-09-05 16:07:03 -07:00
Brad Warren 756c44f7af Release 0.18.0 v0.18.0 2017-09-05 16:06:43 -07:00
Brad Warren d710c441e2 Specify the minimum six version in acme 2017-09-05 10:07:32 -07:00
ohemorangeandBrad Warren 8ad18cbe6e Use ffdhe2048 Nginx DH params to fix Weak-DH bug (#4973)
* Rename plugins.common.install_ssl_options_conf to plugins.common.install_version_controlled_file

* Install ssl_dhparams file

* Add installation test

* Add ssl_dhparam option when making a server block ssl

* add install_ssl_dhparams to Installer common plugin class

* Remove redundant code and tests

* update MANIFEST.in
2017-09-01 07:57:30 -07:00
Noah SwartzandBrad Warren c6bdad4ffb mention that revoke doesn't effect rate limit (#5070)
fixes #2720
2017-09-01 07:57:07 -07:00
Noah SwartzandBrad Warren 39696456db Link to changelog from readme (#5069)
fixes #3420
2017-09-01 07:56:49 -07:00
Brad WarrenandGitHub bbf397a9f9 Fix documentation build failures (#5068)
* sphinxify error_handler docs
2017-08-31 16:35:53 -07:00
r5dandBrad Warren 7cb8c1264f certbot: Update renew command output in quiet mode. (#5062)
* certbot: Update `renew` command output in quiet mode.

* certbot/renewal.py (_renew_describe_results): Update function.
* certbot/tests/main_test.py (_test_renewal_common): Update method.
  Add optional arg `stdout`; Modify `mock_get_utilitiy`, `stdout`.
  (test_quiet_renew): Update method.
2017-08-31 11:01:15 -07:00
Noah SwartzandGitHub b6f8a477b8 Merge pull request #5064 from certbot/letsencrypt-travis
Don't send IRC notifications from forks
2017-08-31 11:19:29 -05:00
Brad Warren 06dd645e85 encrypt channel 2017-08-30 10:34:05 -07:00
Chris JulianandBrad Warren 2bfc92e58d #4071 Mixin to prevent setting return_value after initializing certain Mock objects (#4963)
* Addressing #4071 Wrote an ImmutableReturnMixin to prevent developers overriding return_value in certain Mock objects

* Language

* Loosening the assumption that underlying _mock objects need to be Immutable-like simplifies implementation

* Addressing #4071

* Ensure side_effects and return_values are pushed down to the underlying _mock in FreezableMocks. And IDisplay mocks are no longer frozen in _create_get_utility_mock()

* Edit a handful of tests to not override the mock_get_utility return_value

* Brief explainer of FreezableMock.__setattr__

* Incorporating PR feedback and some compatibility

* FreezableMock __getattr__ needs a shortcut in case of return_value or side_effect

* Changing return_value only forbidden if set before freezing

* Remove unnecessary else block

* Expanded doc strings

* Bring a couple new tests in line with patch_get_utility() norms
2017-08-30 09:52:45 -07:00
Brad Warren 66953435c9 Merge remote-tracking branch 'starttls-everywhere/certbotify' into postfix 2017-08-29 10:44:07 -07:00
Brad Warren dde0bf0821 Remove non-plugin files 2017-08-29 10:42:31 -07:00
Brad Warren 142bc33545 Remove dead code 2017-08-29 10:38:53 -07:00
Brad Warren a339de80f4 Add save() 2017-08-28 17:17:29 -07:00
Brad Warrenandohemorange ae0be73b53 Make common Installer base class (#5055)
* Add installer class

* Add wrapped reverter methods to common.Installer.

* Use Installer class in Apache plugin

* Use Installer class in Nginx plugin

* Don't create reverter in Apache and Nginx plugins
2017-08-28 17:06:09 -07:00
Brad Warren d663f7981a Add _write_config_changes 2017-08-28 15:24:51 -07:00
Brad Warren 72637b2cf6 Add util.check_call 2017-08-28 15:20:22 -07:00
Brad Warren d0ea5958f9 Protect _set_config_var 2017-08-28 14:54:53 -07:00
Brad Warren 4805fb4b88 Add deploy_cert 2017-08-28 14:52:05 -07:00
Brad Warren 11b820c0e4 add set_config_var 2017-08-28 14:41:07 -07:00
Noah SwartzandGitHub 8d362d4469 Merge pull request #5029 from certbot/issue_4792
expand nginx no name error
2017-08-28 14:04:56 -07:00
Ted MaryniczandBrad Warren 133f636817 Update install.rst (#5057)
Minor typo fix in VE para
2017-08-28 11:59:08 -07:00
Noah SwartzandGitHub df71ec33b3 switch from triple quotes to single quotes 2017-08-28 13:45:42 -05:00
Brad Warren b21b66c0c0 Test restart command. 2017-08-25 14:29:50 -07:00
Brad Warren 218e15c9d4 Make restart() more robust. 2017-08-25 14:25:22 -07:00
Brad Warren a6c08a2e25 Update prepare docstring. 2017-08-25 14:03:29 -07:00
Brad Warren 68dc678eed Call config_test in prepare 2017-08-25 14:02:57 -07:00
Brad Warren 5f3be9b1cf test config_test failure 2017-08-25 13:58:45 -07:00
Brad Warren 2ae187b1d6 Update config_test method 2017-08-25 13:55:21 -07:00
Brad Warren b4b5c44750 Check postfix executable is found. 2017-08-25 13:38:07 -07:00
Brad Warren a29a99fb6f Add --postfix-ctl flag. 2017-08-25 13:34:03 -07:00
Brad Warren 0f4c5c2305 Use common installer base 2017-08-25 11:41:30 -07:00
Josh SorefandBrad Warren b2b3285bf5 Add the word instead to renew error (#5053)
Closes #4118
2017-08-25 10:25:59 -07:00
r5dandBrad Warren b43bf8f94a Stop using print in certbot.cli module. (#5028)
* Update cerbot.tests.util.patch_get_utility (#3720)

* Add new arg `stdout_notification` to
  `cerbot.tests.util.patch_get_utility` function.

  If `stdout_notification` is True, then the mock
  interfaces.IDisplay.notification function will print out to stdout.

* Add new arg `stdout_notification` to _create_get_utility_mock
  function.

* Add new function `_stdout_notification`.

* Stop using print in certbot.cli (#3720)

* certbot/cli.py (HelpfulArgumentParser._usage_string)
(HelpfulArgumentParser.__init__): Update methods.
* certbot/tests/cli_test.py (test_cli_ini_domains, test_no_args)
(test_install_abspath, test_help, test_help_no_dashes)
(test_parse_domains, test_preferred_challenges, test_server_flag)
(test_must_staple_flag, test_no_gui, test_staging_flag)
(test_dry_run_flag, test_option_was_set)
(test_encode_revocation_reason, test_force_interactive)
(test_deploy_hook_conflict, test_deploy_hook_matches_renew_hook)
(test_deploy_hook_sets_renew_hook, test_renew_hook_conflict)
(test_renew_hook_matches_deploy_hook)
(test_renew_hook_does_not_set_renew_hook, test_max_log_backups_error)
(test_max_log_backups_success, test_webroot_map)
(test_report_config_interaction_str)
(test_report_config_interaction_iterable): Update tests.
* certbot/tests/main_test.py (test_certificates)
(test_certonly_abspath, test_certonly_bad_args)
(test_agree_dev_preview_config): Update tests.

* certbot: Refactor cli_test.ParseTest.

* certbot/tests/cli_test.py (ParseTest._unmocked_parse): Rename parse
to _unmocked_parse.
(parse): New method.
(ParseTest._help_output, ParseTest.test_cli_ini_domains)
(ParseTest.test_no_args, ParseTest.test_install_abspath)
(ParseTest.test_help, ParseTest.test_help_no_dashes)
(ParseTest.test_parse_domains, ParseTest.test_preferred_challenges)
(ParseTest.test_server_flag, ParseTest.test_must_staple_flag)
(ParseTest.test_no_gui, ParseTest.test_staging_flag)
(ParseTest.test_dry_run_flag, ParseTest.test_option_was_set)
(ParseTest.test_encode_revocation_reason)
(ParseTest.test_force_interactive)
(ParseTest.test_deploy_hook_conflict)
(ParseTest.test_deploy_hook_matches_renew_hook)
(ParseTest.test_deploy_hook_sets_renew_hook)
(ParseTest.test_renew_hook_conflict)
(ParseTest.test_renew_hook_matches_deploy_hook)
(ParseTest.test_renew_hook_does_not_set_renew_hook)
(ParseTest.test_max_log_backups_error)
(ParseTest.test_max_log_backups_success): Update methods.

* certbot: Refactor cli_test.SetByCliTest

* certbot/tests/cli_test.py (SetByCliTest.test_webroot_map)
(SetByCliTest.test_report_config_interaction_str)
(SetByCliTest.test_report_config_interaction_iteratable)
(_call_set_by_cli): Update methods.

* certbot: cli: Fix style.

* certbot/cli.py (HelpfulArgumentParser.__init__): Update method.

* certbot: Revert changes to tests.util.patch_get_utility

* certbot/tests/util.py (patch_get_utility): Remove
`stdout_notification` arg.
(_creat_get_utility_mock): Remove `stdout_notification` arg.
(_stdout_notification): Remove function.

* certbot: Revert changes to MainTest.

* certbot/tests/main_test.py
(MainTest.test_certificates, MainTest.test_certonly_abspath)
(MainTest.test_certonly_bad_args): Update methods.

* certbot: cli_test.py: Remove 'pylint: disable' lines.

* certbot/tests/cli_test.py (ParseTest.parse): Update method.
(_call_set_by_cli): Update function.
2017-08-25 10:05:58 -07:00
Brad Warren 60c6cc5f2a Write enhance() 2017-08-24 15:26:52 -07:00
Brad Warren 00e28592b6 Add supported_enhancements 2017-08-24 15:18:40 -07:00
Brad Warren b92df1b71c Remove unused find_postfix_cf 2017-08-24 15:15:41 -07:00
Brad Warren baf0d3343a Remove postfix version notes 2017-08-24 15:13:02 -07:00
Brad Warren cc3896d5d4 Add test_lock_error 2017-08-24 15:12:11 -07:00
Brad Warren b94e268f83 Remove unused certs_only_config 2017-08-24 15:05:39 -07:00
Brad Warren b9177948d3 Remove _write_config 2017-08-24 15:05:24 -07:00
Brad Warren 3b2e9e49be Remove unneeded instance variables 2017-08-24 15:04:36 -07:00
Brad Warren 0efc02d6ee Lock the Postfix config dir 2017-08-24 15:03:11 -07:00
Brad Warren 967a1830e6 Rewrite get_all_names 2017-08-24 14:59:25 -07:00
Brad Warren 90ffe2aac0 Remove legacy get_all_certs_and_keys() method 2017-08-24 09:04:57 -07:00
Brad Warren b342f40c2b remove old comments 2017-08-23 15:16:36 -07:00
Brad Warren 83e37acc8b group IPlugin methods 2017-08-23 15:16:07 -07:00