Commit Graph
4201 Commits
Author SHA1 Message Date
Liam Marshall 211c2bb33d Remove SSLCACertificatePath from removed directives
SSLCACertificatePath is sometimes important to preserve.
2015-11-10 19:41:30 -06:00
Brad Warren 7d4beacce8 Added better error messages on redirect failure 2015-11-10 16:59:22 -08:00
Peter Eckersley 7dcf8a32f4 Only send the major version of OS X 2015-11-10 16:50:58 -08:00
Peter Eckersley 8b9a271900 "Really" finalise User Agent tests
- Add an extra test for the default UA string
 - Fixes: get_os_info() is returning a tuple, not a string
 - Workaround: Argument preprocessing is dangerous for test cases
2015-11-10 16:50:58 -08:00
Peter Eckersley a4885e491a Finish user agent changes:
- revert changes to acme/, instead living with its current baroque API
 - add an extremely mockable test case
2015-11-10 16:50:57 -08:00
Brad Warren 553592b2c8 Revert "Revert all changes in cleanup, temporary or otherwise"
This reverts commit 0c197c955e.
2015-11-10 16:32:05 -08:00
Brad Warren 3c00afd55c Revert "Removed revert_challenge_config"
This reverts commit 0143d77362.
2015-11-10 16:31:52 -08:00
Chhatoi Pritam Baral 0bbe69b36a Mock existence of nginx binary 2015-11-11 05:49:34 +05:30
Brad Warren 1bb063e870 Corrected crash recovery in client and added tests 2015-11-10 16:03:18 -08:00
Chhatoi Pritam Baral 414321fca6 Fix #1281: Check if nginx binary exists 2015-11-11 04:50:16 +05:30
Brad Warren 60147eb529 Define state of checkpoints when save fails 2015-11-10 14:52:18 -08:00
Liam Marshall 1f6ef1f4b1 Add tests for existing cert removal and newcert directives 2015-11-10 16:04:23 -06:00
Joona Hoikkala 3074ef996a Refactored the argument and the code to use --domain instead of --domains, which was semantically incorrect 2015-11-10 12:29:08 +02:00
Joona Hoikkala 096c689fba Added help text for -d flag 2015-11-10 12:03:15 +02:00
Joona Hoikkala 85675d709c Case insensitive matching 2015-11-10 11:20:33 +02:00
Peter Eckersley baaeab5fa1 Fix lints & glitches 2015-11-09 22:44:26 -08:00
sagi 1880689065 Add --hsts and --uir CLI flags 2015-11-10 06:41:59 +00:00
Peter Eckersley 88cc01301a Creation & plumbing for user agent 2015-11-09 22:17:38 -08:00
Liam Marshall 30c44ef1e2 Fix lint errors 2015-11-09 22:13:36 -06:00
Liam Marshall e63fa279a4 Reintroduce cert_key, remove bad logging 2015-11-09 22:13:36 -06:00
Liam Marshall b26c138938 Wire in everything, remove cert_key
Add debug. Will be removed.

Logging
2015-11-09 22:13:36 -06:00
Liam Marshall 1d2ba931b3 Improve the implementation of the suggestion
Write the code to set directives

Fix logging in _remove_existing_ssl_directives

Fix logging statement
2015-11-09 22:13:25 -06:00
Liam Marshall 18da7dfce2 Implement @pde's suggestions for Apache
From this IRC log:
2015-11-02 16:31:29	@pdeee	for >= 2.4.8:
2015-11-02 16:32:23	@pdeee	add new SSLCertificateFile pointing to fullchain.pem
2015-11-02 16:33:10	@pdeee	remove all preexisting SSLCertificateFile, SSLCertificateChainFile, SSLCACertificatePath, and possibly other fields subject to careful research :)
2015-11-02 16:33:21	@pdeee	for < 2.4.8:
2015-11-02 16:34:03	@pdeee	add SSLCertificateFile pointing to cert.pem
2015-11-02 16:34:42	@pdeee	and SSLCertificateChainFile pointing to chain.pem
2015-11-02 16:34:50	xamnesiax	gotcha
2015-11-02 16:34:55	@pdeee	remove all preexisting/conflicting entries
2015-11-02 16:35:19	xamnesiax	Am I correct to assume that this can all be done from deploy_certs in the apache configurator?
2015-11-02 16:36:32	xamnesiax	deploy_cert *
2015-11-02 16:36:48	@pdeee	I think so
2015-11-02 16:36:59	@pdeee	again, jdkasten may wish to say more

Pull strings out for find_dir

A bit of logging

Add version logging

Logging, temporarily remove one branch

of the conditional for testing

Fix bad directive stringgrabbing code

Fix directive removal logic

Grab string from tree to be removed
2015-11-09 22:12:39 -06:00
Joona Hoikkala 747b7ca507 More robust way of detecting the mod_macro vhosts 2015-11-10 05:34:15 +02:00
Peter Eckersley 6fbcebd4ab Merge pull request #1385 from joohoi/modmacro
Ignore mod_macro vhosts, and display notification
2015-11-09 19:03:11 -08:00
Brad Warren 0143d77362 Removed revert_challenge_config 2015-11-09 18:47:38 -08:00
Brad Warren 0c197c955e Revert all changes in cleanup, temporary or otherwise 2015-11-09 18:44:30 -08:00
Peter Eckersley 7b352d3d80 Handle FreeBSD and Windows 2015-11-09 18:21:39 -08:00
rootandPeter Eckersley fb35a11c73 get_os_info : wrangle OS and major version number in a semi-portable way 2015-11-09 17:47:12 -08:00
rootandPeter Eckersley 6bf0aa4d25 --user-agent flag 2015-11-09 17:42:46 -08:00
Peter Eckersley 6c3ea0d2a1 Merge branch 'config_sanity' 2015-11-09 16:19:21 -08:00
Peter Eckersley d29ab2a523 Make final tweaks for landing #1421 2015-11-09 16:18:51 -08:00
bmw 4dc3ee7446 Merge pull request #1390 from letsencrypt/1274
Remove nonsensical Apache config directives
2015-11-09 15:41:27 -08:00
bmw af0229d38a Merge pull request #1401 from letsencrypt/ssl-options
Downgrade a very excitable security comment to an XXX
2015-11-09 15:38:04 -08:00
sagi de338c7309 Add tests for Upgrade-Insecure-Requests 2015-11-09 22:36:00 +00:00
Peter Eckersley 1711197b7f Merge pull request #1415 from letsencrypt/1408
Fix ExperimentalBootstrap on Mac
2015-11-09 11:39:40 -08:00
Joona Hoikkala 0d01cbfc92 Refactored the port check from NamespaceConfig init to the validation function 2015-11-08 23:05:33 +02:00
Joona Hoikkala 0c4456bd7e Fixed the comment to be accurate 2015-11-08 22:57:58 +02:00
Joona Hoikkala a4b7d0d5c1 Making linter happy by removing the unused import 2015-11-08 22:44:32 +02:00
Joona Hoikkala 59b544be3b Moved the validation to configurator 2015-11-08 22:26:01 +02:00
Joona Hoikkala 3128bab7bd Added domain to renewer test mock 2015-11-08 22:21:11 +02:00
Joona Hoikkala 9077dfdbac Fixed the messages 2015-11-08 21:46:57 +02:00
Joona Hoikkala ee38585eb4 Refactored domain flag checks into their own helper function to clear space for future checks 2015-11-08 21:43:48 +02:00
Joona Hoikkala c80e4c0f2f Added comment to clarify FQDN regex 2015-11-08 21:14:12 +02:00
Joona Hoikkala e63aaf7faf Changed the checks to be more readable and better semantically 2015-11-08 21:08:50 +02:00
Joona Hoikkala ae080349c5 Changed the errors import 2015-11-08 21:04:48 +02:00
Joona Hoikkala d6a3286a67 Fixed the wildcard domain string match 2015-11-08 20:50:39 +02:00
Joona Hoikkala b35ebafe16 Fixed last half-assed commit to tests 2015-11-08 20:49:44 +02:00
Joona Hoikkala 57726e6384 Use python2.6 compatible test assertions 2015-11-08 20:42:24 +02:00
Joona Hoikkala 2ac7a2a9ea Check configuration sanity for domain flag 2015-11-08 20:23:01 +02:00