Peter Eckersley
a5073b28c3
New description of webroot for the UI
2016-04-05 10:58:42 -07:00
Brad Warren
237adfdce2
I was told to cleanup after myself
2016-04-04 16:19:41 -07:00
Brad Warren
558806e2b7
add cli_flag for noninteractive
2016-04-04 14:26:07 -07:00
Brad Warren
4505b68a9a
put generator expression on one line
2016-04-04 14:05:46 -07:00
Brad Warren
641f0c7422
simplify error handling
2016-04-04 13:06:00 -07:00
Brad Warren
7458324932
logging++
2016-04-04 10:57:02 -07:00
Brad Warren
17c495732d
Don't pause when showing errors
2016-04-04 10:38:34 -07:00
Brad Warren
987aa82371
more UI polish
2016-04-04 10:32:01 -07:00
Brad Warren
bf0c2306c6
Try and make ncurses less ugly
2016-04-04 09:49:56 -07:00
Brad Warren
22c924bb1c
more interactive webroot polish
2016-04-04 09:45:48 -07:00
Brad Warren
ba62ed45c0
basic interactive webroot?
2016-04-01 18:39:13 -07:00
Brad Warren
f1f0d1de12
premature optimization is the root of all evil
2016-04-01 18:08:27 -07:00
Brad Warren
547147b8ac
Start of IDisplay code for webroot
2016-04-01 17:57:46 -07:00
Brad Warren
1acd50a0ce
Remove the need for extra processing to support --csr + --webroot
2016-04-01 17:07:54 -07:00
Brad Warren
82efffdf62
inline _match_webroot_with_domains
2016-04-01 16:52:48 -07:00
Brad Warren
7070b99699
make prepare a noop
2016-04-01 16:45:59 -07:00
Brad Warren
1f4daf0874
factor out _create_challenge_dirs
2016-04-01 16:42:45 -07:00
Brad Warren
b1bdc4590d
Move webroot processing to webroot.py
2016-04-01 16:16:17 -07:00
Brad Warren
f663a6f961
add _WebrootPathAction to webroot.py
2016-04-01 14:24:52 -07:00
Brad Warren
c83c09e12b
Add _WebrootMapAction to webroot.py
2016-04-01 14:07:42 -07:00
Brad Warren
ca7049dabc
add webroot_path parsing functions to webroot.py
2016-04-01 13:21:57 -07:00
Benjamin Neff
1390c96e65
handle permission denied during cleanup
...
if the .well-known/acme-challenge was created before and the user has no
permissions to delete it, it failed at cleanup.
2016-03-16 14:52:51 +01:00
Roy Wellington Ⅳ
e9d981aceb
Change zope's classProvides to be a class decorator.
...
When attempting to import any module that uses
zope.interface.classProvides in Python 3, a TypeError is raised; it
reads:
TypeError: Class advice impossible in Python3. Use the @provider
class decorator instead.
Following the listed advice seems to function in Python 3.
2016-02-20 00:41:01 -08:00
Roy Wellington Ⅳ
b6142c13d6
Change zope's implements to be a class decorator.
...
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:
TypeError: Class advice impossible in Python3. Use the @implementer
class decorator instead.
Following the listed advice seems to function in Python 3.
2016-02-20 00:37:40 -08:00
Filip Ochnik
4d9f487e89
Handle rmdir failure
2016-02-17 17:04:10 +08:00
Filip Ochnik
9b5ff7bcd7
Remove acme-challenge after cleaning up all challenges
2016-02-16 20:46:42 +08:00
Filip Ochnik
780c9ce2ae
Refactor path logic in webroot plugin
2016-02-16 20:36:46 +08:00
Peter Eckersley
a774922f8f
Revert "Revert "Allow webroot-map and --csr to exist together.""
...
This reverts commit d65a3c65c2
2016-02-08 18:14:55 -08:00
Peter Eckersley
d65a3c65c2
Revert "Allow webroot-map and --csr to exist together."
2016-02-08 17:25:47 -08:00
Peter Eckersley
6df94bf68d
Better webroot configuration error
...
Fixes : #2377
2016-02-06 13:48:09 -08:00
Filip Ochnik
2a6d3bedb6
Fix missing --webroot-path handling in webroot plugin
2016-01-15 11:37:20 +07:00
Brad Warren
d45865a601
Cleanup
2015-12-11 19:14:23 -08:00
Brad Warren
2d52559466
Cleanup comment
2015-12-11 18:12:46 -08:00
Brad Warren
74927613e9
Fixed lint issues
2015-12-11 18:03:52 -08:00
Luca Beltrame
2b942d97b2
Address review comments
...
- move the umask call before the try/except block
- move comment in _prepare_single to the umask call
Simplify the code comments, too.
Tests still pass.
2015-12-07 11:17:29 +01:00
Luca Beltrame
edf3a4ed73
Make webroot usable also when running as non-root (GH #1795 )
...
Thanks to @aburch's suggestions, the logic has been changed:
- Set umask before creating folders and files
- Leverage os.makedirs' mode option in conjunction with umask
The program still tries to change owner / group, but in case of errors
it continues gracefully.
Tests have been updated, and they pass.
2015-12-07 10:49:24 +01:00
Peter Eckersley
a191daf3ee
Merge pull request #1597 from lbeltrame/fix-webroot-permissions
...
Fix webroot permissions [mergeable, but enhancements also requested]
2015-12-01 19:07:06 -08:00
Peter Eckersley
f4dd660403
Oops!
...
- Finish a partial commit, providing what are perhaps excessively detailed and
mystical errors in improbable cases.
2015-12-01 16:50:39 -08:00
Peter Eckersley
06e273413b
Fix nits and address review comments
2015-12-01 16:33:35 -08:00
Peter Eckersley
6c9ddf34e6
Merge remote-tracking branch 'origin/master' into webroot
2015-11-30 20:57:27 -08:00
Peter Eckersley
328f8cdc5b
Document --webroot-path
2015-11-30 18:24:40 -08:00
Luca Beltrame
a58c939c8d
Change ownership of the validation paths as well
...
Match them with the parent directory they're in.
2015-11-25 14:26:00 +01:00
Luca Beltrame
a71c3ed90c
Fix issues from review
...
- Put chmod argument to os.chmod (oops)
- Add permissions adjustments for challenge files, too
2015-11-24 10:15:18 +01:00
Patrick Figel
c175ff955e
Remove Content-Type checks from http-01
...
Content-Type type restrictions were removed in ACME, see
https://github.com/ietf-wg-acme/acme/commit/69ac2baade014796e5258a077e7600921cd1879d
fixes #1595
2015-11-24 09:54:33 +01:00
Luca Beltrame
768c7cd9c0
Fix webroot permissions
...
Take them from the parent directory where the webroot is.Should fix issue #1389
2015-11-22 15:16:50 +01:00
Peter Eckersley
f48ef6ded9
lint
2015-11-21 10:59:15 -08:00
Peter Eckersley
f2f9d33e03
Update _path_for_achall
...
Borrowing from @grubberr's changes at:
https://github.com/letsencrypt/letsencrypt/pull/1284/files#diff-522ab130649a0ce14df40114d4ccd0b5L111
2015-11-21 10:59:15 -08:00
Peter Eckersley
ffe6226edc
Switch webroot.prepare() to use config.webroot_map
2015-11-21 10:59:15 -08:00
Peter Eckersley
e1f0fcca8f
Move --webroot-path processing into cli.py
...
Since it is now interdependent with --domains
(This is much more elegant than trying to APIify the interaction)
2015-11-21 10:59:15 -08:00
Peter Eckersley
19f348b416
First implementation of -w for multi-webroot specification
...
* Will need tests and cleanup
2015-11-21 10:59:15 -08:00
Peter Eckersley