mirror of
https://github.com/certbot/certbot.git
synced 2026-07-26 15:48:52 +02:00
Jacob Hoffman-AndrewsandBrad Warren
cacee80c51
It's relatively finicky to make a CSR appropriate to pass to poll_and_request_issuance. I think most users want to be able to give a list of domains and a private key, and get back a CSR. This branch adds that functionality to crypto_util. Note that the two new functions take arguments, and return values, as PEM-encoded buffers. This is a departure from some existing ACME interfaces that take PyOpenSSL types. I've discussed with the Certbot team, and we agree that this is broadly the direction the ACME API should take, so that users of the module don't need to import PyOpenSSL themselves, or use its primitives. * Add make_csr. * accept privkey * Tweak API. * Remove make_csr from certbot package. * Skip test in older Pythons. * Move get_Extensions call under protection. * Remove assertIn because not backwards-compatible. * Fix encoding, and use PEM. * Fix test * Fix tests on py35. * Fix error in test. * Make import_csr_file always return PEM. Also delete get_sans_from_csr (unused) and get_names_from_csr (newly unused). * Fix function doc. * Fix indent * Fix call of obtain_certificate_from_Csr * lint * Handle review feedback. * Fix test.